1166 auto create quaters insted of service call#1167
Merged
Conversation
service can be skiped, we make it mandatory by adding it to the model a lot of test depends on it so i'm updating them too it resolves #1166
Collaborator
Author
|
I'd test it on the staging first but I'm not sure how to do it @pollygee |
pollygee
approved these changes
Jun 19, 2026
pollygee
left a comment
pollygee
left a comment
Collaborator
There was a problem hiding this comment.
Sorry it took me so long to get to this!
This looks great.
Should we delete the Quarter factory? Or maybe update it to find or create? I'm thinking we might run into conflicts if the school year factory creates quarters then we have a quarter factory that also tries to create more factories? It might not be intuitive for future us or contributors that they don't' need to create quarters doesn't have to block this work.
Collaborator
Author
|
ah, good point @pollygee ! let me fix that part as I'm here |
Collaborator
Author
|
depends on #1178 |
Collaborator
|
I missed your question before about staging. When we merge we auto deploy to staging. We manually deploy to prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Resolves
(link the issue url, e.g. Resolves #1166
Checklist
Notes