Add gsm: advisory field in support of issue #305; Added 1 brand new GSM advisory#960
Add gsm: advisory field in support of issue #305; Added 1 brand new GSM advisory#960jasnow wants to merge 2 commits intorubysec:masterfrom
Conversation
Specs must be separated by empty lines.
postmodern
left a comment
There was a problem hiding this comment.
What happens when this GSM advisory eventually get's assigned a CVE or added to GitHub Security Advisories DB? Will we end up with a GHSA- and CVE- file? Could the github_advisory_sync.rb automatically rename GSM-* to CVE-*/GHSA-*?
|
Good questions
I think that the PR#585 lint check's purpose is to flag duplicate advisories.
We could watch for it and add a feature when it happens. |
|
I'm hesitant about adding GSM advisory IDs to the database because of one advisory that never got assigned a CVE. bundler-audit would also need to be updated, as it expects either a I reviewed encryptor's GitHub issues's and noted two things:
Either someone else needs to request the CVE on behalf of encryptor, or maybe a CVE is not needed and GSM-2016-16 might be invalid. Long-term, I might be open to trying to consume GitLab's Advisory database along with GitHub's Advisory DB and NVD. |
|
OK |
Add gsm: advisory field in support of issue #305