Rewrite callstack/require_all to use caller_locations

Replace fragile caller string parsing with caller_locations, which
returns structured Thread::Backtrace::Location objects. No more
regex matching against Ruby version-specific caller formats.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: trans

HISTORY.md

@@ -27,7 +27,8 @@ Changes:
   * Adapt `Module#attr_setter` to frozen-string-literal. (PR#287)
   * Update `Binding#__LINE__` and `__FILE__` to use `source_location`.
   * Replace `URI.escape`/`URI.unescape` with `CGI.escape`/`CGI.unescape`.
-  * Match Ruby 3.4 caller syntax in `Kernel#__DIR__`, `#callstack`, `#require_all`. (PR#308)
+  * Rewrite `Kernel#callstack`, `#require_all`, `#load_all` to use `caller_locations`
+    instead of parsing caller strings with regex.
   * Switch CI from Travis to GitHub Actions.
 
 * Bug Fixes

lib/core/facets/kernel/callstack.rb

@@ -3,40 +3,22 @@ module Kernel
   alias_method :pp_callstack, :caller
   alias_method :pp_call_stack, :caller
 
-  # Parse a caller string and break it into its components,
-  # returning an array composed of:
-  #
-  # * file (String)
-  # * lineno (Integer)
-  # * method (Symbol)
+  # Returns the call stack as an array of [file, lineno, method] entries.
   #
   # For example, from irb
   #
   #     callstack(1)
   #
   # _produces_ ...
   #
-  #     [["(irb)", 2, :irb_binding],
-  #       ["/usr/lib/ruby/1.8/irb/workspace.rb", 52, :irb_binding],
-  #       ["/usr/lib/ruby/1.8/irb/workspace.rb", 52, nil]]
-  #
-  # Note: If the user decides to redefine caller() to output data
-  # in a different format, _prior_ to requiring this, then the
-  # results will be indeterminate.
+  #     [["(irb)", 2, :irb_binding], ...]
   #
   # CREDIT: Trans
 
   def callstack(level = 1)
-    call_str_array = pp_callstack(level)
-    stack = []
-    call_str_array.each{ |call_str|
-      file, lineno, method = call_str.split(':')
-      if method =~ /in [`'](.*)'/ then
-        method = $1.intern()
-      end
-      stack << [file, lineno.to_i, method]
-    }
-    stack
+    caller_locations(level).map do |loc|
+      [loc.path, loc.lineno, loc.label&.to_sym]
+    end
   end
 
   alias_method :call_stack, :callstack
@@ -53,4 +35,3 @@ def callstack(level=1)
 
   alias_method :call_stack, :callstack
 end
-

lib/core/facets/kernel/require_all.rb

@@ -1,23 +1,15 @@
 module Kernel
 
-  # Require a pattern of files relatvie to the current file.
-  # This makes is easy to require an entire directory, for instance:
+  # Require a pattern of files relative to the current file.
+  # This makes it easy to require an entire directory, for instance:
   #
   #   require_all 'core_ext/*'
   #
-  # NOTE: This method used to allow glob-based requires from the $LOAD_PATH,
-  # but this was deprecated in favor of relative requiring only, as it is
-  # consider the typical usecase, and globbing from the $LOAD_PATH is a
-  # bit dangerous. Better options exist for globbing the $LOAD_PATH such as
-  # the +plugins+ gem.
 
   def require_all(pattern)
-    c = caller.first
-    fail "Can't parse #{c}" unless c.rindex(/:\d+(:in [`'].*')?$/)
-    file = $` # File.dirname(c)
-    if /\A\((.*)\)/ =~ file # eval, etc.
-      raise LoadError, "require_relative is called in #{$1}"
-    end
+    loc = caller_locations(1, 1).first
+    file = loc.absolute_path || loc.path
+    raise LoadError, "require_all is called in #{loc.label}" unless file
     glob = File.expand_path(pattern, File.dirname(file))
     Dir.glob(glob).each do |absolute|
       require absolute
@@ -26,17 +18,13 @@ def require_all(pattern)
 
   # Same as #require_all, but for #load.
   def load_all(pattern, safe=nil)
-    c = caller.first
-    fail "Can't parse #{c}" unless c.rindex(/:\d+(:in [`'].*')?$/)
-    file = $` # File.dirname(c)
-    if /\A\((.*)\)/ =~ file # eval, etc.
-      raise LoadError, "require_relative is called in #{$1}"
-    end
+    loc = caller_locations(1, 1).first
+    file = loc.absolute_path || loc.path
+    raise LoadError, "load_all is called in #{loc.label}" unless file
     glob = File.expand_path(pattern, File.dirname(file))
     Dir.glob(glob).each do |absolute|
       load absolute, safe
     end
   end
 
 end
-