Review Comparable, Dir, and Object; add Dir.find

- Deprecate Comparable#clip (use Comparable#clamp, Ruby 2.4+)
- Redefine Comparable#bound as alias for clamp
- Add Dir.find as convenience wrapper around Find.find
- Deprecate Dir.recurse/ls_r (use Dir.find instead)
- Remove Object#dup!/try_dup (dup works on all objects since Ruby 2.4)
- Remove Exception#set_message (broken)
- Deprecate Exception#error_print (use Exception#full_message, Ruby 2.5+)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: trans

HISTORY.md

@@ -85,6 +85,10 @@ Changes:
   * Remove `Object#dup!` and `Object#try_dup` (plain `dup` works on all objects since Ruby 2.4).
   * Remove `Exception#set_message` (broken — did not actually change the message).
   * Deprecate `Exception#error_print` (use `Exception#full_message`, adopted by Ruby in 2.5).
+  * Deprecate `Comparable#clip` (use `Comparable#clamp`, adopted by Ruby in 2.4).
+  * Redefine `Comparable#bound` as alias for `clamp`.
+  * Add `Dir.find` as convenience wrapper around Ruby's `Find.find`.
+  * Deprecate `Dir.recurse` / `Dir.ls_r` (use `Dir.find` or `Find.find` instead).
   * Remove misplaced `applique/file_helpers` from core (test infrastructure).
   * Drop unused `test_files` directive from gemspec. (PR#301)
 

lib/core/facets/comparable/bound.rb

@@ -1 +1,13 @@
-require 'facets/comparable/clip'
+module Comparable
+
+  # Alias for Comparable#clamp. Reads more naturally in some contexts.
+  #
+  #   4.bound(2, 7)  #=> 4
+  #   9.bound(2, 7)  #=> 7
+  #   1.bound(2, 7)  #=> 2
+  #
+  def bound(lower, upper=nil)
+    upper ? clamp(lower, upper) : clamp(lower..)
+  end
+
+end

lib/core/facets/comparable/clip.rb

@@ -1,38 +1,9 @@
 module Comparable
 
-  # Returns self if above the given lower bound, or
-  # within the given lower and upper bounds,
-  # otherwise returns the the bound of which the
-  # value falls outside.
-  #
-  #   4.clip(3)    #=> 4
-  #   4.clip(5)    #=> 5
-  #   4.clip(2,7)  #=> 4
-  #   9.clip(2,7)  #=> 7
-  #   1.clip(2,7)  #=> 2
-  #
-  # CREDIT Florian Gross, Trans
-
+  # @deprecated Use Comparable#clamp instead (built-in since Ruby 2.4).
   def clip(lower, upper=nil)
-    return lower if self < lower
-    return self unless upper
-    return upper if self > upper
-    return self
+    warn "Comparable#clip is deprecated. Use Comparable#clamp instead.", uplevel: 1
+    upper ? clamp(lower, upper) : clamp(lower..)
   end
 
-  # Returns self if above the given lower bound, or
-  # within the given lower and upper bounds,
-  # otherwise returns the the bound of which the
-  # value falls outside.
-  #
-  #   4.bound(3)    #=> 4
-  #   4.bound(5)    #=> 5
-  #   4.bound(2,7)  #=> 4
-  #   9.bound(2,7)  #=> 7
-  #   1.bound(2,7)  #=> 2
-  #
-  # CREDIT: Florian Gross
-
-  alias_method :bound, :clip
-
 end

lib/core/facets/dir/find.rb

@@ -0,0 +1,20 @@
+require 'find'
+
+class Dir
+
+  # Recursively traverse a directory, yielding each file and directory path.
+  # Supports Find.prune to skip subtrees.
+  #
+  #   Dir.find('.') do |path|
+  #     puts path
+  #   end
+  #
+  # Returns an enumerator if no block is given.
+  #
+  # This is a convenience wrapper around Ruby's Find.find.
+
+  def self.find(*paths, ignore_error: true, &block)
+    Find.find(*paths, ignore_error: ignore_error, &block)
+  end
+
+end

lib/core/facets/dir/recurse.rb

@@ -1,35 +1,17 @@
+require 'facets/dir/find'
+
 class Dir
 
-  # Recursively scan a directory and pass each file to the given block.
-  #
-  #   Dir.recurse('.') do |path|
-  #     # ...
-  #   end
-  #
-  # CREDIT: George Moschovitis
-  #
-  # TODO: If fully compatible, reimplement as alias of Find.find,
-  # or just copy and paste Find.find code here if it looks more robust.
-  #
+  # @deprecated Use Dir.find or Find.find instead.
   def self.recurse(path='.', &block)
-    list = []
-    stoplist = ['.', '..']
-    Dir.foreach(path) do |f|
-      next if stoplist.include?(f)
-      filename = (path == '.' ? f : path + '/' + f)
-      list << filename
-      block.call(filename) if block
-      if FileTest.directory?(filename) and not FileTest.symlink?(filename)
-        list.concat(Dir.recurse(filename, &block))
-      end
-    end
-    list
+    warn "Dir.recurse is deprecated. Use Dir.find or Find.find instead.", uplevel: 1
+    Dir.find(path, &block)
   end
 
-  # Same as Dir#recurse.
+  # @deprecated Use Dir.find or Find.find instead.
   def self.ls_r(path='.', &block)
-    recurse(path, &block)
+    warn "Dir.ls_r is deprecated. Use Dir.find or Find.find instead.", uplevel: 1
+    Dir.find(path, &block)
   end
 
 end
-