core: Fix cursor not updating in all hover cases#23396
Open
robinmiau wants to merge 4 commits into
Open
Conversation
Update mouse cursor handling for hover events and object changes.
kjarosh
added
A-input
Contributor
|
Looks like this is failing some tests. I guess it's updating the hovered item when it shouldn't be? Meanwhile; do you have any content that can test this change? |
Dinnerbone
added
the
waiting-on-author
Contributor
Author
|
@Dinnerbone Sorry for the long wait. Yes, that was the issue. I changed it so stationary mouse hover changes go through the existing rollover path instead, while preserving keyboard-focus hover. The failing tab-ordering tests pass now. I've only tested it on my website, but it requires registration, so I'm not sure if that's helpful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cases where the cursor was not updated correctly:
When the mouse was stationary but the hovered object changed (e.g. an animated object moved under the cursor),
mouse_cursor()was never called because hover events were skipped. Fixed by re-evaluating the cursor whenever the hovered object changes, regardless of mouse movement.When moving the mouse within the same interactive object,
mouse_cursor()was never called since the hovered object pointer did not change. This caused the cursor to remain stuck, most visibly in TextFields where links should show a hand cursor but did not. Fixed by re-evaluating the cursor on every mouse move over the same object.