core: Fix focusing behavior in SWF 8- vs 9+#23398
Draft
ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
Draft
core: Fix focusing behavior in SWF 8- vs 9+#23398ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
Lord-McSweeney
added
A-core
As explained in the comment in player.rs, in SWF 9+, when needing to clear the focus, the focus only actually resets if the stage was clicked and the movie is AVM2.
ChrisCPI
force-pushed
the
fix-swf8-9-focus-behavior
branch
from
70ff70f to
dcb8877
Compare
Contributor
Author
|
Marking this as a draft for now, since I recently came across some other weird behavior (only happening in SWF version 9 specifically) which this PR doesn't account for, so I need to look into it some. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining changes from #23244, fixes #23182
The behavior is explained in the added comment in player.rs, which has been revised to hopefully be more clear.