fix: Mark StringEnums as non-exhaustive

Because of the private variant, which shouldn't be matched, they should never be exhaustive.

Author: zecakeh

CHANGELOG.md

@@ -4,6 +4,10 @@ Breaking changes:
 
 * The list_room response changes the fields `version`, `join_rules`, `guest_access` and `history_visibility` to be an option
 * The list_room response changes the `join_rules` field to be `Option<SpaceRoomJoinRule>`
+* `background_update::run::v1::JobName` is now non-exhaustive.
+* `RoomSortOrder` and `RoomDirection` in `rooms::list_rooms::v1` are now non-
+  exhaustive. Their `PartialOrd` and `Ord` implementations now use their string
+  representation instead of the order in which they are defined in the enum.
 
 Improvement:
 

Cargo.toml

@@ -42,7 +42,7 @@ cloned_instead_of_copied = "warn"
 dbg_macro = "warn"
 disallowed_types = "warn"
 empty_line_after_outer_attr = "warn"
-# exhaustive_enums = "warn"
+exhaustive_enums = "warn"
 # exhaustive_structs = "warn"
 inefficient_to_string = "warn"
 macro_use_imports = "warn"

src/background_updates/run/v1.rs

@@ -3,7 +3,7 @@
 use ruma::{
     api::{request, response, Metadata},
     metadata,
-    serde::StringEnum,
+    serde::{PartialEqAsRefStr, StringEnum},
 };
 
 const METADATA: Metadata = metadata! {
@@ -39,8 +39,9 @@ impl Response {
     }
 }
 
-#[derive(Clone, PartialEq, StringEnum)]
+#[derive(Clone, PartialEqAsRefStr, Eq, StringEnum)]
 #[ruma_enum(rename_all = "snake_case")]
+#[non_exhaustive]
 pub enum JobName {
     /// Recalculate the stats for all rooms.
     PopulateStatsProcessRooms,

src/rooms/list_rooms/v1.rs

@@ -3,7 +3,7 @@ use ruma::{
     api::{metadata, request, response, Metadata},
     events::room::{guest_access::GuestAccess, history_visibility::HistoryVisibility},
     room::RoomType,
-    serde::StringEnum,
+    serde::{OrdAsRefStr, PartialEqAsRefStr, PartialOrdAsRefStr, StringEnum},
     space::SpaceRoomJoinRule,
     OwnedRoomAliasId, OwnedRoomId, OwnedUserId, UInt,
 };
@@ -82,8 +82,9 @@ impl Response {
 }
 
 /// Enum to define the sorting method of rooms.
-#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, StringEnum)]
+#[derive(Clone, PartialEqAsRefStr, Eq, PartialOrdAsRefStr, OrdAsRefStr, StringEnum)]
 #[ruma_enum(rename_all = "snake_case")]
+#[non_exhaustive]
 pub enum RoomSortOrder {
     /// Sort by name alphabetical
     Name,
@@ -129,7 +130,8 @@ pub enum RoomSortOrder {
 }
 
 /// Enum to define the sort order direction.
-#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, StringEnum)]
+#[derive(Clone, PartialEqAsRefStr, Eq, PartialOrdAsRefStr, OrdAsRefStr, StringEnum)]
+#[non_exhaustive]
 pub enum SortDirection {
     /// Sort direction backward.
     #[ruma_enum(rename = "b")]