fix: Third party identifiers parsing#33
Merged
Merged
Conversation
zecakeh
reviewed
Apr 17, 2025
Current version requires that third party ids contains the fields `validated_at` and `added_at`, but Synapse admin API documentation does not list those fields in `create_or_modify` endpoint: https://element-hq.github.io/synapse/latest/admin_api/user_admin_api.html#create-or-modify-account Since those fields are currently required, the endpoint may fail to deserialize legitimate requests.
zecakeh
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version requires that third party ids contains the fields
validated_atandadded_at, but Synapse admin API documentation does not list those fields forcreate_or_modifyendpoint: https://element-hq.github.io/synapse/latest/admin_api/user_admin_api.html#create-or-modify-accountSince those fields are currently required, the endpoint may fail to deserialize legitimate requests which do not send the mentioned fields.