Fix #1547: add mobile navigation toggle to settings sub-pages#1812
Open
Keegil wants to merge 1 commit into
Open
Fix #1547: add mobile navigation toggle to settings sub-pages#1812Keegil wants to merge 1 commit into
Keegil wants to merge 1 commit into
Conversation
Project the account settings mobile navigation toggle from the shared account shell so every settings sub-page keeps access to the sidenav on smaller screens. Add focused specs for the account shell and shared container projection used by the mobile toolbar. runbox#1547 Closes runbox#1547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm test -- --watch=false --browsers=FirefoxHeadless --include src/app/account-app/account-app.component.spec.tskarma-firefox-launchercould not find a Firefox binary and requestedFIREFOX_BIN./node_modules/.bin/tsc -p src/tsconfig.spec.json --noEmit./node_modules/.bin/eslint src/app/account-app/account-app.component.spec.ts src/app/account-app/account-app.component.ts src/app/account-app/account-app.component.html src/app/account-app/account-welcome.component.ts src/app/account-app/account-welcome.component.html src/app/account-app/account-upgrades.component.ts src/app/account-app/account-upgrades.component.html src/app/runbox-components/runbox-container.spec.ts./node_modules/.bin/ng build --configuration production --base-href=/app/ runbox7Issue
Closes #1547.
Notes
The browser-based Angular spec run was able to compile and start Karma after sandbox escalation, but it could not launch
FirefoxHeadlessbecause no Firefox binary is installed in this environment.