You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The xapian revert makes sense to me. The Sentry PR (50b8e5d) switched declare var to declare let and changed some .apply() calls to use spread syntax, and this just puts it all back to the state that was working. The Observable<boolean> tightening on deleteLocalIndex is a nice bonus over what master had.
ESLint approach is a bit inconsistent (blanket /* eslint-disable */ in the two loader files vs targeted // eslint-disable-next-line no-var in the other three) but totally fine given the loader files already had a stack of rule disables.
E2E changes look good. Adding cy.intercept + cy.wait before assertions is definitely the right move over relying on 10s timeouts. Splitting the subaccount tests out into their own file keeps things tidy. The mockserver receipt endpoint fix is a reasonable defensive change too.
Minor thing: double space in declare var IDBFS; in both loader files, and the PR title says "revert(index)" but it touches the loader/patching code as well. Neither worth changing.
castaway
changed the title
revert(index): User action updates in messagelist work again
Re-enable user actions (angular v16/eslint update broke some xapian things subtly)
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this fix the user actions issues? Maybe
Does it pass tests? Not on my machine..
After a stern talking to, passes tests and user actions work !