Skip to content

Re-enable user actions (angular v16/eslint update broke some xapian things subtly)#1823

Open
castaway wants to merge 3 commits into
runbox:masterfrom
shadow-dot-cat:castaway/user_actions_from_master
Open

Re-enable user actions (angular v16/eslint update broke some xapian things subtly)#1823
castaway wants to merge 3 commits into
runbox:masterfrom
shadow-dot-cat:castaway/user_actions_from_master

Conversation

@castaway
Copy link
Copy Markdown
Contributor

@castaway castaway commented Apr 15, 2026

Does this fix the user actions issues? Maybe
Does it pass tests? Not on my machine..

After a stern talking to, passes tests and user actions work !

@castaway castaway marked this pull request as ready for review April 16, 2026 14:13
@castaway castaway requested a review from piratefinn April 16, 2026 15:03
piratefinn

This comment was marked as low quality.

@piratefinn
Copy link
Copy Markdown
Contributor

piratefinn commented Apr 16, 2026

The xapian revert makes sense to me. The Sentry PR (50b8e5d) switched declare var to declare let and changed some .apply() calls to use spread syntax, and this just puts it all back to the state that was working. The Observable<boolean> tightening on deleteLocalIndex is a nice bonus over what master had.

ESLint approach is a bit inconsistent (blanket /* eslint-disable */ in the two loader files vs targeted // eslint-disable-next-line no-var in the other three) but totally fine given the loader files already had a stack of rule disables.

E2E changes look good. Adding cy.intercept + cy.wait before assertions is definitely the right move over relying on 10s timeouts. Splitting the subaccount tests out into their own file keeps things tidy. The mockserver receipt endpoint fix is a reasonable defensive change too.

Minor thing: double space in declare var IDBFS; in both loader files, and the PR title says "revert(index)" but it touches the loader/patching code as well. Neither worth changing.

@castaway castaway changed the title revert(index): User action updates in messagelist work again Re-enable user actions (angular v16/eslint update broke some xapian things subtly) Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants