Skip to content

fix(routes): set sub-app page titles #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrakeMikels wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(routes): set sub-app page titles #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/account-app/account-app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ import { DomainRegisterComponent } from '../domainregister/domainregister.compon
RouterModule.forChild([
{
path: 'account',
title: 'Runbox Account',
canActivateChild: [RMMAuthGuardService, NoProductsForSubaccountsGuard],
children: [
{
Expand Down
35 changes: 19 additions & 16 deletions src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,41 +102,45 @@ const routes: Routes = [
path: '', outlet: 'headertoolbar',
component: HeaderToolbarComponent
},
{ path: 'index_dev.html', component: AppComponent },
{ path: 'app', component: AppComponent },
{ path: 'index_dev.html', component: AppComponent, title: 'Runbox Mail' },
{ path: 'app', component: AppComponent, title: 'Runbox Mail' },
{ path: '',
component: AppComponent,
title: 'Runbox Mail',
children: [
{
path: 'compose',
component: DraftDeskComponent
component: DraftDeskComponent,
title: 'Runbox Compose'
},
{
path: 'overview',
component: StartDeskComponent
component: StartDeskComponent,
title: 'Runbox Overview'
},
{
path: 'welcome',
component: WelcomeDeskComponent
component: WelcomeDeskComponent,
title: 'Runbox Welcome'
}
]
},
{ path: 'start', component: OverviewComponent },
{ path: 'help', component: HelpComponent },
{ path: 'dev', loadChildren: () => import('./dev/dev.module').then(m => m.DevModule) },
{ path: 'dkim', loadChildren: () => import('./dkim/dkim.module').then(m => m.DkimModule) },
{ path: 'calendar', loadChildren: () => import('./calendar-app/calendar-app.module').then(m => m.CalendarAppModule) },
{ path: 'changelog', loadChildren: () => import('./changelog/changelog.module').then(m => m.ChangelogModule) },
{ path: 'contacts', loadChildren: () => import('./contacts-app/contacts-app.module').then(m => m.ContactsAppModule) },
{ path: 'onscreen', loadChildren: () => import('./onscreen/onscreen.module').then(m => m.OnscreenModule) },
{ path: 'start', component: OverviewComponent, title: 'Runbox Start' },
{ path: 'help', component: HelpComponent, title: 'Runbox Help' },
{ path: 'dev', title: 'Runbox Dev', loadChildren: () => import('./dev/dev.module').then(m => m.DevModule) },
{ path: 'dkim', title: 'Runbox DKIM', loadChildren: () => import('./dkim/dkim.module').then(m => m.DkimModule) },
{ path: 'calendar', title: 'Runbox Calendar', loadChildren: () => import('./calendar-app/calendar-app.module').then(m => m.CalendarAppModule) },
{ path: 'changelog', title: 'Runbox Changelog', loadChildren: () => import('./changelog/changelog.module').then(m => m.ChangelogModule) },
{ path: 'contacts', title: 'Runbox Contacts', loadChildren: () => import('./contacts-app/contacts-app.module').then(m => m.ContactsAppModule) },
{ path: 'onscreen', title: 'Runbox Onscreen', loadChildren: () => import('./onscreen/onscreen.module').then(m => m.OnscreenModule) },
{ path: 'identities', redirectTo: '/account/identities' },
{ path: 'account-security', redirectTo: '/account/security' },
// can't handle it with a simple redirectTo because it'd lose the query params
// (https://github.com/angular/angular/issues/13315)
{ path: 'domainregistration', component: DomainRegisterRedirectComponent },
{ path: 'domainregistration', component: DomainRegisterRedirectComponent, title: 'Runbox Domain Registration' },
]
},
{ path: 'login', component: LoginComponent }
{ path: 'login', component: LoginComponent, title: 'Runbox Login' }
];

@NgModule({
Expand Down Expand Up @@ -213,4 +217,3 @@ export class AppModule {
);
}
}