Skip to content

fix(mail): clarify sender list action labels#1835

Open
KaannKara wants to merge 2 commits into
runbox:masterfrom
KaannKara:clarify-sender-list-actions
Open

fix(mail): clarify sender list action labels#1835
KaannKara wants to merge 2 commits into
runbox:masterfrom
KaannKara:clarify-sender-list-actions

Conversation

@KaannKara
Copy link
Copy Markdown

Fixes #1698.

Summary

  • add explicit allowlist/blocklist wording for the sender rules menu
  • keep the existing allow/block actions unchanged
  • cover the action labels with a focused component spec

Tests

  • npx tsc -p src/tsconfig.spec.json --noEmit
  • npx eslint src/app/mailviewer/singlemailviewer.component.ts src/app/mailviewer/singlemailviewer.component.spec.ts
  • npm run lint (passes with existing warnings)
  • npm run policy (passes; reports existing historical commit-message notes)
  • npm run build (passes with existing Angular/CommonJS warnings)
  • npm run test -- --watch=false --browsers=ChromeHeadless --include=src/app/mailviewer/singlemailviewer.component.spec.ts (blocked: ChromeHeadless launcher is not registered in this checkout)

Used OpenAI Codex to inspect the issue, implement the patch, and run local validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Settings Allow Sender and Block Sender Email/Domain functions can cause confusion

1 participant