Constrain avatar size in printed messages#1838
Open
bolasse1234 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1824 by adding print-only styles for the avatar bar before the message HTML is loaded into the print iframe. The printed iframe receives raw
innerHTML, so Angular component styles fromapp-avatar-barare not present there; without those styles, avatar images can render at their intrinsic size.The added styles only target
app-avatar-bar, leaving message body images unchanged.Validation
npx eslint src/app/mailviewer/singlemailviewer.component.ts src/app/mailviewer/singlemailviewer.component.spec.ts(passes with existing warnings)npx tsc -p src/tsconfig.spec.json --noEmitnpx ng build --base-href=/app/ runbox7(passes with existing project warnings)I could not run the Karma browser test locally because Firefox/Chrome/Edge are not available on PATH in this environment.
Disclosure
I used AI assistance to inspect the print path and draft this small patch, then validated the changed code with the commands above.