Skip to content

Use app favicon#1839

Open
Wheezily wants to merge 1 commit into
runbox:masterfrom
Wheezily:bounty/use-app-favicon
Open

Use app favicon#1839
Wheezily wants to merge 1 commit into
runbox:masterfrom
Wheezily:bounty/use-app-favicon

Conversation

@Wheezily
Copy link
Copy Markdown

Fixes #922.

The app shell was still loading the favicon from the old site logo at /_img/index/logobox.png. This points the page at the app favicon instead and adds src/favicon.ico to the Angular build assets so the file is emitted.

Validation:

  • node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('angular.json','utf8')); if(!fs.existsSync('src/favicon.ico')) process.exit(1); console.log('angular.json ok; favicon exists');"
  • git diff --check

I did not run a full Angular build locally because dependencies are not installed in this checkout.

@Wheezily
Copy link
Copy Markdown
Author

Added a fuller local validation pass:

  • Installed dependencies in a Node 18 container with the Cypress binary download disabled.
  • Fetched full git history so the changelog step can resolve its base commit.
  • Ran npm run build; it passed with the existing Angular/CommonJS/Sass warnings.
  • Re-ran git diff --check; it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web app: favicon

1 participant