fix(account-details): sort countries by display name#1840
Open
voyagi wants to merge 2 commits into
Open
Conversation
Add tests for runbox#1443 that require country options to be sorted by display name and rebuilt without duplicates.
Populate the country list from countries-and-timezones entries, sort by localized country name, and replace the list on reload instead of appending duplicates. Fixes runbox#1443.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npx ng test --include=src/app/account-details/personal-details.component.spec.ts --watch=false --browsers=FirefoxHeadlessffa747d0, before the fix commit is applied.npx tsc -p src/tsconfig.spec.json --noEmitnpm run buildpassed when run under Git Bash on Windows so the package script's POSIX shell syntax is interpreted correctly.AI disclosure
Codex assisted with issue triage, implementation, and tests for
src/app/account-details/personal-details.component.tsandsrc/app/account-details/personal-details.component.spec.ts.Fixes #1443