Skip to content

fix(mailviewer): hide empty overflow menu#1841

Open
moosnelly wants to merge 2 commits into
runbox:masterfrom
moosnelly:codex/fix-empty-mailviewer-overflow
Open

fix(mailviewer): hide empty overflow menu#1841
moosnelly wants to merge 2 commits into
runbox:masterfrom
moosnelly:codex/fix-empty-mailviewer-overflow

Conversation

@moosnelly
Copy link
Copy Markdown

Summary

  • hide the mail viewer overflow button when a plaintext message has no hidden toolbar actions
  • keep the overflow button visible for hidden HTML-only actions
  • correct the overflow thresholds for View source, HTML settings, and Original HTML

Tests

  • RED: npm test -- --watch=false --browsers=ChromeHeadless --include=src/app/mailviewer/singlemailviewer.component.spec.ts failed with missing hasHiddenToolbarActions
  • GREEN: FIREFOX_BIN="/Users/moosaalinaseer/Library/Caches/ms-playwright/firefox-1522/firefox/Nightly.app/Contents/MacOS/firefox" npm test -- --watch=false --include=src/app/mailviewer/singlemailviewer.component.spec.ts -> 10 SUCCESS
  • npm run lint -- runbox7 -> 0 errors, existing warnings only
  • npm run build -> passed with existing warnings

AI disclosure

This PR was developed with AI assistance from OpenAI Codex, with changes reviewed and verified locally before submission.

Fixes #656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu item to the right of "View Source" is empty on plaintext messages.

1 participant