Skip to content

Commit 334749a

Browse files
author
Claude
committed
osrs-best-in-slot: one panel + two opt-in off-by-default media captures
**What changed since the last approved commit (`74b0c77`)** - **One plugin, one panel.** The two previously separate plugin classes are merged into a single `AccountConnectPlugin` with one config panel and one `@PluginDescriptor` (verified: exactly one descriptor in `src/main`). No change to what the base feature uploads. - **Opt-in trade screenshot (off by default).** When the user explicitly enables it, a screenshot of the trade-confirmation window is uploaded as delivery proof on trade completion. In-config disclosure (verbatim): *"When enabled, this captures a screenshot of your trade confirmation window — which shows the other player's name and the items traded — when a trade completes, and uploads it with your osrsbestinslot.com link token to osrsbestinslot.com's servers as delivery proof. Nothing else is sent, and nothing is captured while this is off."* The toggle also carries a RuneLite `warning=`: *"This uploads a screenshot of your trade window (which includes the other player's name and the traded items) to osrsbestinslot.com. Only enable it if you agree to that."* Default: **false**. - **Opt-in general-store clip (off by default).** When enabled, a short muted video clip (default 6 s @ 10 fps) of the game screen while a shop interface is open is uploaded as delivery proof. In-config disclosure (verbatim): *"When enabled, this records a short muted video clip of your game screen while a shop is open and uploads it, together with your osrsbestinslot.com link token, to osrsbestinslot.com's servers as delivery proof. Only the rendered game frames are captured — no keyboard, mouse, password or other data is sent. Off by default."* Encoded in pure Java (jcodec) — no native code, no subprocess. Default: **false**. - **Change-gated uploads.** The account snapshot now uploads only when the account state actually changes (previously a fixed 30 s cadence), cutting request volume to osrsbestinslot.com by ~95%, and backs off on HTTP 429. **Privacy stance** - Both media features are **opt-in and off by default** — nothing is captured or uploaded unless the user turns the toggle on. - Each toggle shows a plain-language disclosure of exactly what is captured and where it goes, in the config panel, at the point of enabling. - Captures are **passive** — only rendered game frames / the trade window are read. No keyboard, mouse, password, email, payment, or Jagex-account credentials are read or sent (RuneLite does not expose those to plugins). - The base account-data upload is unchanged from the approved `74b0c77`; the hub `warning=` is updated to disclose the two new optional media features. **Build**: `./gradlew clean build` green on the exported public tree (JDK 11); tests + `check` pass.
1 parent c154f38 commit 334749a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

plugins/osrs-best-in-slot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
repository=https://github.com/osrsbis/account-connect.git
2-
commit=74b0c77b5a50318ef130c9f07a39c7933c998a28
2+
commit=e90e5c05b062e21a2b86542facac44f708aa4902
33
authors=osrsbis
4-
warning=This plugin submits your IP address and uploads your account data (skills, quests, achievement diaries, equipment, inventory and bank contents) to osrsbestinslot.com to auto-fill its calculators, keyed by a link token you paste. Only enable it if you are comfortable with that data being uploaded.
4+
warning=This plugin submits your IP address and uploads your account data (skills, quests, achievement diaries, equipment, inventory and bank contents) to osrsbestinslot.com to auto-fill its calculators, keyed by a link token you paste. Two optional features, both off by default, additionally upload media when you enable them: a screenshot when you complete a trade, and a short video clip of your general store visits. Only enable it if you are comfortable with that data being uploaded.

0 commit comments

Comments
 (0)