Open
Conversation
|
New plugin |
Author
|
Temporarily closing — had to flip source repo from private to public so CI can clone. Reopening now. |
ajkatz
added a commit
to ajkatz/runelite-goal-planner
that referenced
this pull request
Apr 16, 2026
Plugin-hub CI (runelite/plugin-hub#11552) rejected the first build with: - Do not create fresh Gson instances, always @Inject the client's Gson. - Use ComponentID or InterfaceID instead of WidgetInfo or WidgetID Fixes: 1. GoalPlannerPlugin.java: replace deprecated WidgetID constants with net.runelite.api.gameval.InterfaceID: WidgetID.INVENTORY_GROUP_ID -> InterfaceID.INVENTORY WidgetID.BANK_GROUP_ID -> InterfaceID.BANKMAIN WidgetID.COLLECTION_LOG_ID -> InterfaceID.COLLECTION Values are identical (149, 12, 621 respectively); only the import / constant name changed. 2. GoalStore.java + WikiCaRepository.java: stop constructing Gson ourselves. Added Gson to the @Inject constructor and dropped the `new Gson()` / `new GsonBuilder().create()` usage. Static final GSON -> instance field `gson`. 3. Tests: update all new GoalStore(configManager) call sites to pass `new com.google.gson.Gson()` as the second arg (tests aren't shipped to plugin-hub, so the deprecation rule doesn't apply there). Verified: ./gradlew clean test passes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Author
|
For anyone testing this plugin pre-merge, I've set up a Discord community for Goal Planner — https://discord.gg/CFQsA3fmh7 — feature ideas, bug sanity-checks, and general feedback. Real bug reports still go on GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal Planner
A goal/grind tracker and planner plugin for OSRS with prerequisite graph seeding.
Source: https://github.com/ajkatz/runelite-goal-tracker
What it does
Note on existing Goal Tracker plugin
There is an existing
goal-trackerplugin by Toofifty. This submission is a separate plugin with a distinct name and scope:The positioning is complementary, not competing. Different UX and different target user.
Known rough edges (to address in a follow-up)
Apologies in advance — a lot of functionality is hidden in right-click menus and context actions in this first release. I'm planning a UX pass in a follow-up to surface the most-used actions more prominently and streamline discoverability. The
[Experimental v0.1.0]tag in the description reflects that this is a first cut.Technical notes
[Experimental v0.1.0]in description - persistence format may change before 1.0