Skip to content

Update 07flip to 5866739#11687

Open
UserD40 wants to merge 3 commits intorunelite:masterfrom
UserD40:update-07flip-1777387534
Open

Update 07flip to 5866739#11687
UserD40 wants to merge 3 commits intorunelite:masterfrom
UserD40:update-07flip-1777387534

Conversation

@UserD40
Copy link
Copy Markdown
Contributor

@UserD40 UserD40 commented Apr 28, 2026

Update 07flip plugin to commit 5866739.

Replaces the chatbox-rendered price card (which was unreliable due to chatbox rebuild scripts clobbering injected child widgets) with a movable Java2D overlay anchored to the GE setup screen. Right-click the overlay to pick from suggested buy/sell prices; the selected price auto-fills the custom price input. Also adds cyan empty-slot hints when a panel right-click queue is awaiting the user to pick a slot.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 28, 2026

Copy link
Copy Markdown
Member

@tylerwgrass tylerwgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

07flip: "build" must be set
in file /tmp/pluginhub-package9514200939117029686/07flip/repo/runelite-plugin.properties
You must add a build=standard or build=gradle entry.
build=standard is recommended unless you have dependencies or other changes to your build.gradle.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 30, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 1, 2026
@UserD40
Copy link
Copy Markdown
Contributor Author

UserD40 commented May 1, 2026

Thanks for the review @tylerwgrass! Added build=standard to runelite-plugin.properties and updated the PR to point at the new commit (5356606). No third-party dependencies, so standard is appropriate. Let me know if anything else needs adjusting.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 1, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Copy Markdown
Contributor

do not use Client#menuAction. what are you trying to achieve?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 1, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 2, 2026
@UserD40
Copy link
Copy Markdown
Contributor Author

UserD40 commented May 2, 2026

Thanks @LlemonDuck. Context: we have a movable overlay that appears while the GE setup screen is open and shows our recommended buy/sell prices for the item the user is trading. Right-clicking the overlay let the user pick one of those prices to populate the GE custom price input. The Client#menuAction call was being used as a convenience to programmatically click the "Enter price" button so the user did not need a separate click before the chatbox auto-filled.

I have removed the menuAction call (commit d08c43d). The flow is now:

  1. User right-clicks our overlay ? picks a price.
  2. We arm the pending value and our existing overlay highlights the in-game "Enter price" button in yellow as a hint.
  3. User clicks "Enter price" themselves; the chatbox opens; our ScriptPostFired handler for the chatbox-input-open script fills the input.

No programmatic menu invocation, and the MenuAction import has been removed from O7FlipPlugin.java. Let me know if anything else needs adjusting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants