Skip to content

Update immersive-dialogue#12379

Merged
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
DjilanoS:immersive-dialogue-drag-feature-1.0.2
Jun 8, 2026
Merged

Update immersive-dialogue#12379
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
DjilanoS:immersive-dialogue-drag-feature-1.0.2

Conversation

@DjilanoS

@DjilanoS DjilanoS commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

TLDR
Adds mouse interaction and repositioning to the relocated dialogue panel. All existing native keyboard controls (Esc / Spacebar / 1–5) still work — clicking via menuActions API is additive.

Changed

  • New defaults: backdrop padding 4, avatar backdrop on, bottom margin 150, animate head on, drag mode on.
  • Options no longer render the [1]–[5] number prefix / "use keys" hint (click and native number keys both still select).
  • Continue prompt now reads "Click to continue".
  • Position sliders widened (bottom margin 0–2160, horizontal offset ±1920) and drag is clamped to keep the box on-screen at any resolution.

Adds mouse interaction and repositioning to the relocated dialogue panel. All existing native keyboard controls (Esc / Spacebar / 1–5) still work — clicking via menuActions API is additive.
@runelite-github-app

runelite-github-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

Internal use only: Reviewer details Maintainer details

@DjilanoS

DjilanoS commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

I have a feeling Runelit hub checks failed due to the user of menuActions, if so here's a bit more information on how and why I use client.menuAction(..):

A left‑click on that panel is forwarded to the game's own continue / option‑select action via client.menuAction(..., MenuAction.WIDGET_CONTINUE, ...), targeting the native dialogue widgets (ChatLeft/ChatRight.CONTINUE, Chatmenu.OPTIONS) by their component IDs.

This affects only non‑combat conversation UI; it grants no information, efficiency, or capability the player doesn't already have, only the convenience of clicking where the dialogue is shown.

The client.menuAction(..) call results in the same server interaction the native click it mirrors would normally cause so no extra or different packets are sent to the server, and nothing is sent unless the user clicks.

See DialogueWidgetController.java#L441 for "continue to click" usage.

See DialogueMouseListener.java#L166 for "select options" usage.

Feature in action:
Screen Recording 2026-06-03 at 12 06 25 PM

@riktenx

riktenx commented Jun 6, 2026

Copy link
Copy Markdown
Member

yeah, use of client.menuAction is not allowed for this

i understand this usage may seem benign but it's a question of accidentally tripping jagex's macro detection, which programmatic server interactions outside of the vanilla jagex client code paths will do. we cannot host features that might get users banned

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
@DjilanoS

DjilanoS commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

yeah, use of client.menuAction is not allowed for this

i understand this usage may seem benign but it's a question of accidentally tripping jagex's macro detection, which programmatic server interactions outside of the vanilla jagex client code paths will do. we cannot host features that might get users banned

Allright, totally understand! Was worth a try.

  • Removed: menuActions that supported click actions all together
  • Rewrote README
  • Added support for System message dialogues in the custom dialogue box

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 7, 2026
@runelite-github-app runelite-github-app Bot merged commit a3631e4 into runelite:master Jun 8, 2026
3 checks passed
@DjilanoS DjilanoS deleted the immersive-dialogue-drag-feature-1.0.2 branch June 9, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants