Update to chathighlightplayer#12409
Open
Aiirik wants to merge 9 commits into
Open
Conversation
As per request, I have removed the following features as requested by admins: -Remove the generic player highlighting feature (the always highlight groups). -Remove the customizable temporary highlight duration. You may set it to a duration at or below 60 seconds. Now it will only temp highlight players from 5 seconds - 60 seconds (hard limit on 60 seconds) similar to how the plugin started. No more permanent highlight. I worked on most of these features. I thought it was a cool feature I was adding but had no ideal it was breaking the rules. It would only highlighted players in your surroundings that you would select, but I can understand your point. So sorry about that. I hope this resolves the issues.
fixed version number
cleaned up file added highlight timer from 1 minute max to 2 minute max.
Merge pull request runelite#15 from Jasper-VP/fix-code-formatting Restore code formatting (whitespace only) Pure formatting cleanup addressing the review feedback about removed line breaks. No functional changes. Normalize CRLF line endings to LF Restore consistent tab indentation (de-indented method bodies; split joined lines) Restore the blank lines between and within methods that were dropped during the feature-removal commits, matching the pre-removal formatting Normalize the over-indented @configitem annotation params in the config
Fixed minimap dot not showing for highlighted player Added toggle to enable or disable minimap dot for highlighted player
updated version number
|
|
|
Internal use only: Reviewer details Maintainer details |
Added new highlight mode and toggle for highlight mode (Tile, Outline)
Updated config layout to try and group settings better Added a toggle to display gamemessage when a player is highlighted Fixed: Removed 0 Seconds as an option in the highlight duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed minimap dot not displaying for highlighted player
Added toggle for minimap dot for highlighted player
Added new highlight mode (tile, outline)
Added new gamemessage option to display in chat who has been highlighted
Fixed up the config to group up settings better