Skip to content

Squeaky toy v2.3#12424

Merged
runelite-github-app[bot] merged 3 commits into
runelite:masterfrom
H-Mill:squeaky-toy-v2.3
Jun 6, 2026
Merged

Squeaky toy v2.3#12424
runelite-github-app[bot] merged 3 commits into
runelite:masterfrom
H-Mill:squeaky-toy-v2.3

Conversation

@H-Mill

@H-Mill H-Mill commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
  • Add two SFX triggers:
    • Player Kill (triggers when you kill another player)
    • Player death (triggers when you die)
  • Add 5 more built in SFX (mostly death sfx)
  • Move toggle options into collapsible section
  • Add Global attack section
  • Add toggles to Received Attacks section

@runelite-github-app

runelite-github-app Bot commented Jun 5, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jun 5, 2026

Copy link
Copy Markdown

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

- Move the 3 option toggles into a collapsible section
- Add ability to toggle entire non-weapon related sections
- Allow deleting last remaining sound groups
@riktenx riktenx closed this Jun 6, 2026
@riktenx riktenx reopened this Jun 6, 2026
@raiyni raiyni added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
@H-Mill

H-Mill commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

@raiyni can you specify which SFX exactly, some of these are widely used across youtube videos, etc. I've also got a branch that adds the ability for people to use their own sound clips, however it has to use some file i/o to read the .wav files. I could include that in this PR, but last time I had it in a PR, it sat here for over a week

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
@runelite-github-app runelite-github-app Bot merged commit b887f0d into runelite:master Jun 6, 2026
5 checks passed
@H-Mill H-Mill deleted the squeaky-toy-v2.3 branch June 6, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants