linter

Author: runk

.eslintrc

@@ -0,0 +1,90 @@
+# borrowed from https://github.com/nodejs/node/blob/master/.eslintrc
+env:
+  node: true
+  mocha: true
+
+rules:
+  # Possible Errors
+  # http://eslint.org/docs/rules/#possible-errors
+  comma-dangle: [2, "only-multiline"]
+  no-control-regex: 2
+  no-debugger: 2
+  no-dupe-args: 2
+  no-dupe-keys: 2
+  no-duplicate-case: 2
+  no-empty-character-class: 2
+  no-ex-assign: 2
+  no-extra-boolean-cast: 2
+  no-extra-parens: [2, "functions"]
+  no-extra-semi: 2
+  no-func-assign: 2
+  no-invalid-regexp: 2
+  no-irregular-whitespace: 2
+  no-negated-in-lhs: 2
+  no-obj-calls: 2
+  no-proto: 2
+  no-unexpected-multiline: 2
+  no-unreachable: 2
+  use-isnan: 2
+  valid-typeof: 2
+
+  # Best Practices
+  # http://eslint.org/docs/rules/#best-practices
+  no-fallthrough: 2
+  no-multi-spaces: 2
+  no-octal: 2
+  no-redeclare: 2
+  no-self-assign: 2
+  no-unused-labels: 2
+
+  # Strict Mode
+  # http://eslint.org/docs/rules/#strict-mode
+  strict: [2, "global"]
+
+  # Variables
+  # http://eslint.org/docs/rules/#variables
+  no-delete-var: 2
+  no-undef: 2
+  no-unused-vars: [2, {"args": "none"}]
+
+  # Node.js and CommonJS
+  # http://eslint.org/docs/rules/#nodejs-and-commonjs
+  no-mixed-requires: 2
+  no-new-require: 2
+  no-path-concat: 2
+  no-restricted-modules: [2, "sys", "_linklist"]
+
+  # Stylistic Issues
+  # http://eslint.org/docs/rules/#stylistic-issues
+  comma-spacing: 2
+  eol-last: 2
+  indent: [2, 2, {SwitchCase: 1}]
+  key-spacing: [2, {mode: "minimum"}]
+  keyword-spacing: 2
+  linebreak-style: [2, "unix"]
+  max-len: [2, 120, 2]
+  new-parens: 2
+  no-mixed-spaces-and-tabs: 2
+  no-multiple-empty-lines: [2, {max: 2}]
+  no-trailing-spaces: 2
+  quotes: [2, "single", "avoid-escape"]
+  semi: 2
+  space-before-blocks: [2, "always"]
+  space-before-function-paren: [2, "never"]
+  space-in-parens: [2, "never"]
+  space-infix-ops: 2
+  space-unary-ops: 2
+
+  # ECMAScript 6
+  # http://eslint.org/docs/rules/#ecmascript-6
+  arrow-parens: [2, "always"]
+  arrow-spacing: [2, {"before": true, "after": true}]
+  constructor-super: 2
+  no-class-assign: 2
+  no-confusing-arrow: 2
+  no-const-assign: 2
+  no-dupe-class-members: 2
+  no-new-symbol: 2
+  no-this-before-super: 2
+  prefer-const: 2
+  template-curly-spacing: 2

index.js

@@ -1 +1,2 @@
+'use strict';
 module.exports = require('./lib/proxy');

lib/cache.js

@@ -1,15 +1,15 @@
+'use strict';
 var path = require('path'),
   fs = require('fs'),
   crypto = require('crypto'),
   mkdirp = require('mkdirp');
 
 
 function Cache(opts) {
-
-  this.opts = opts || {}
+  this.opts = opts || {};
   this.opts.ttl = (opts.ttl || 1800) * 1000;
   this.opts.friendlyNames = opts.friendlyNames;
-  this.opts.path = opts.path || __dirname + '/../cache';
+  this.opts.path = opts.path || path.join(__dirname, '/../cache');
 
   this.locks = {};
 
@@ -69,12 +69,12 @@ function Cache(opts) {
     // create lock
     locks[key] = true;
 
-    mkdirp.sync(path.dir, 0755);
+    mkdirp.sync(path.dir, 511); // 511 is decimal equvivalent of 0777
 
     var file = fs.createWriteStream(path.full);
     file.on('finish', function() {
       // release lock
-      delete(locks[key]);
+      delete (locks[key]);
       file.close();
     });
 
@@ -114,14 +114,14 @@ function Cache(opts) {
 
 
   this.unlink = function(key) {
-    delete(this.locks[key]);
+    delete (this.locks[key]);
     fs.unlinkSync(this.getPath(key).full);
   };
 
-};
+}
 
 Cache.NOT_FOUND = 0;
-Cache.EXPIRED   = 2;
-Cache.FRESH     = 4;
+Cache.EXPIRED = 2;
+Cache.FRESH = 4;
 
 module.exports = Cache;

lib/proxy.js

@@ -1,3 +1,4 @@
+'use strict';
 var http = require('http'),
   net = require('net'),
   https = require('https'),
@@ -7,11 +8,12 @@ var http = require('http'),
   path = require('path'),
   request = require('request'),
   log4js = require('log4js');
-  Cache = require('./cache');
+
+var Cache = require('./cache');
 
 
 // To avoid 'DEPTH_ZERO_SELF_SIGNED_CERT' error on some setups
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";
+process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
 
 exports.log = null;
 
@@ -23,15 +25,15 @@ exports.opts = {};
 var mitmAddress;
 
 // Random header to prevent sending requests in a cycle
-var cycleCheckHeader = 'x-npm-proxy-cache-' + Math.round(Math.random() * 10000)
+var cycleCheckHeader = 'x-npm-proxy-cache-' + Math.round(Math.random() * 10000);
 
 exports.powerup = function(opts) {
 
   exports.opts = opts || {};
 
   var options = {
-    key: fs.readFileSync(__dirname + '/../cert/dummy.key', 'utf8'),
-    cert: fs.readFileSync(__dirname + '/../cert/dummy.crt', 'utf8')
+    key: fs.readFileSync(path.join(__dirname, '/../cert/dummy.key'), 'utf8'),
+    cert: fs.readFileSync(path.join(__dirname, '/../cert/dummy.crt'), 'utf8')
   };
 
   this.cache = new Cache({
@@ -53,7 +55,7 @@ exports.powerup = function(opts) {
   // it does not support unix sockets.
   if (/^win/i.test(process.platform) && !isNumeric(opts.internalPort)) {
     console.error('Error: On Windows platform you have to specify internal port,\n'
-      +'for example `--internal-port 8081`.');
+      + 'for example `--internal-port 8081`.');
     process.exit(1);
   }
   if (opts.internalPort) {
@@ -88,9 +90,9 @@ exports.httpHandler = function(req, res) {
     dest = schema + '://' + req.headers['host'] + path;
 
   if (req.headers[cycleCheckHeader]) {
-    res.writeHead(502)
-    res.end('Sending requests to myself. Stopping to prevent cycles.')
-    return
+    res.writeHead(502);
+    res.end('Sending requests to myself. Stopping to prevent cycles.');
+    return;
   }
 
   var params = {
@@ -99,7 +101,7 @@ exports.httpHandler = function(req, res) {
     url: dest
   };
 
-  params.headers[cycleCheckHeader] = 1
+  params.headers[cycleCheckHeader] = 1;
 
   // Carry following headers down to dest npm repository.
   var carryHeaders = ['authorization', 'version', 'referer', 'npm-session', 'user-agent'];
@@ -137,7 +139,7 @@ exports.httpHandler = function(req, res) {
       if (!err && response.statusCode === 200) {
         var file = cache.write(dest);
         r.pipe(file).on('finish', function() {
-          cache.meta(dest, function(err, meta){
+          cache.meta(dest, function(err, meta) {
             if (err)
               throw err;
             respondWithCache(dest, cache, meta, res);
@@ -159,7 +161,7 @@ exports.httpHandler = function(req, res) {
 
         res.end(err ? err.toString() : 'Status ' + response.statusCode + ' returned');
       }
-    }
+    };
 
     var r = request(params);
     r.on('response', onResponse.bind(null, null));
@@ -173,7 +175,6 @@ exports.httpHandler = function(req, res) {
 
 exports.httpsHandler = function(request, socketRequest, bodyhead) {
   var log = exports.log,
-    url = request['url'],
     httpVersion = request['httpVersion'];
 
   log.debug('  = will connect to socket (or port) "%s"', mitmAddress);
@@ -225,22 +226,23 @@ exports.httpsHandler = function(request, socketRequest, bodyhead) {
 
 function bypass(req, res, params) {
   var length = parseInt(req.headers['content-length']);
+  var log = exports.log;
 
-  var onEnd = function (params, res) {
+  var onEnd = function(params, res) {
     return request(params)
-      .on('error', function (err) {
+      .on('error', function(err) {
         log.error('bypass', err);
       })
       .pipe(res, { end: false });
-  }
+  };
 
   if (isNaN(length) || isFinite(length)) {
     onEnd(params, res);
     return;
   }
 
   var raw = new Buffer(length),
-      pointer = 0;
+    pointer = 0;
 
   req.on('data', function(chunk) {
     chunk.copy(raw, pointer);

npm-debug.log

@@ -13,14 +13,16 @@
   "description": "HTTP/HTTPS caching proxy for work with `npm` utility / registry",
   "main": "index.js",
   "devDependencies": {
+    "eslint": "^3.19.0",
     "github-publish-release": "^1.3.3",
     "mocha": "^3.2.0",
     "rimraf": "^2.6.1",
     "uuid": "^3.0.1"
   },
   "scripts": {
-    "test": "mocha -R spec --recursive",
-    "release": "scripts/release"
+    "lint": "eslint -c .eslintrc --fix .",
+    "release": "scripts/release",
+    "test": "mocha -R spec --recursive"
   },
   "repository": {
     "type": "git",