Skip to content

Check the parent snapshot to identify the writable type#17

Merged
gautam-rl merged 1 commit into
mainfrom
gautam-use-parent-for-writable-type
Aug 28, 2025
Merged

Check the parent snapshot to identify the writable type#17
gautam-rl merged 1 commit into
mainfrom
gautam-use-parent-for-writable-type

Conversation

@gautam-rl

@gautam-rl gautam-rl commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

What
Changes getWritableType() to look at the parent snapshot's filesystem instead of the child's, which doesn't even exist at this point.

Why
When creating sandboxes/containers from overlaybd pause images, the first creation works correctly but subsequent attempts fall back to overlayfs mode instead of using overlaybd.

The getWritableType() function was checking the child snapshot's labels and filesystem for overlaybd metadata, but the child snapshot doesn't have a label, and the child snapshot directories don't exist yet at this point. Note that in createMountPoint we were handling this properly for the stype, but not the writeType.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@gautam-rl
gautam-rl requested a review from adam-rl August 28, 2025 04:30

@adam-rl adam-rl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I wonder how this diffs with upstream now.

@gautam-rl
gautam-rl merged commit 21a2ad8 into main Aug 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants