updated unit test expected call args

Author: sid-rl

tests/sdk/test_async_clients.py

@@ -245,7 +245,14 @@ async def test_list(self, mock_async_client: AsyncMock, object_view: MockObjectV
         assert len(objects) == 1
         assert isinstance(objects[0], AsyncStorageObject)
         assert objects[0].id == "obj_123"
-        mock_async_client.objects.list.assert_awaited_once()
+        mock_async_client.objects.list.assert_awaited_once_with(
+            content_type="text",
+            limit=10,
+            name="test",
+            search="query",
+            starting_after="obj_000",
+            state="READ_ONLY",
+        )
 
     @pytest.mark.asyncio
     async def test_upload_from_file(
@@ -268,9 +275,14 @@ async def test_upload_from_file(
 
         assert isinstance(obj, AsyncStorageObject)
         assert obj.id == "obj_123"
-        mock_async_client.objects.create.assert_awaited_once()
-        mock_async_client.objects.complete.assert_awaited_once()
+        mock_async_client.objects.create.assert_awaited_once_with(
+            name="test.txt",
+            content_type="text",
+            metadata=None,
+            ttl_ms=None,
+        )
         http_client.put.assert_awaited_once_with(object_view.upload_url, content=b"test content")
+        mock_async_client.objects.complete.assert_awaited_once()
 
     @pytest.mark.asyncio
     async def test_upload_from_text(self, mock_async_client: AsyncMock, object_view: MockObjectView) -> None:
@@ -292,6 +304,7 @@ async def test_upload_from_text(self, mock_async_client: AsyncMock, object_view:
             name="test.txt",
             content_type="text",
             metadata={"key": "value"},
+            ttl_ms=None,
         )
         http_client.put.assert_awaited_once_with(object_view.upload_url, content="test content")
         mock_async_client.objects.complete.assert_awaited_once()
@@ -316,6 +329,7 @@ async def test_upload_from_bytes(self, mock_async_client: AsyncMock, object_view
             name="test.bin",
             content_type="binary",
             metadata=None,
+            ttl_ms=None,
         )
         http_client.put.assert_awaited_once_with(object_view.upload_url, content=b"test content")
         mock_async_client.objects.complete.assert_awaited_once()
@@ -401,10 +415,12 @@ async def test_upload_from_dir_default_name(
 
         assert isinstance(obj, AsyncStorageObject)
         # Name should be directory name + .tar.gz
-        mock_async_client.objects.create.assert_awaited_once()
-        call_args = mock_async_client.objects.create.call_args
-        assert call_args[1]["name"] == "my_folder.tar.gz"
-        assert call_args[1]["content_type"] == "tgz"
+        mock_async_client.objects.create.assert_awaited_once_with(
+            name="my_folder.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
 
     @pytest.mark.asyncio
     async def test_upload_from_dir_with_ttl(
@@ -429,10 +445,12 @@ async def test_upload_from_dir_with_ttl(
         obj = await client.upload_from_dir(test_dir, ttl=timedelta(hours=2))
 
         assert isinstance(obj, AsyncStorageObject)
-        mock_async_client.objects.create.assert_awaited_once()
-        call_args = mock_async_client.objects.create.call_args
-        # 2 hours = 7200 seconds = 7200000 milliseconds
-        assert call_args[1]["ttl_ms"] == 7200000
+        mock_async_client.objects.create.assert_awaited_once_with(
+            name="temp_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=7200000,  # 2 hours = 7200 seconds = 7200000 milliseconds
+        )
 
     @pytest.mark.asyncio
     async def test_upload_from_dir_empty_directory(
@@ -455,7 +473,12 @@ async def test_upload_from_dir_empty_directory(
 
         assert isinstance(obj, AsyncStorageObject)
         assert obj.id == "obj_123"
-        mock_async_client.objects.create.assert_awaited_once()
+        mock_async_client.objects.create.assert_awaited_once_with(
+            name="empty_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
         http_client.put.assert_awaited_once()
         mock_async_client.objects.complete.assert_awaited_once()
 
@@ -482,7 +505,14 @@ async def test_upload_from_dir_with_string_path(
 
         assert isinstance(obj, AsyncStorageObject)
         assert obj.id == "obj_123"
-        mock_async_client.objects.create.assert_awaited_once()
+        mock_async_client.objects.create.assert_awaited_once_with(
+            name="string_path_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
+        http_client.put.assert_awaited_once()
+        mock_async_client.objects.complete.assert_awaited_once()
 
 
 class TestAsyncRunloopSDK:

tests/sdk/test_clients.py

@@ -202,7 +202,11 @@ def test_create(self, mock_client: Mock, object_view: MockObjectView) -> None:
         assert isinstance(obj, StorageObject)
         assert obj.id == "obj_123"
         assert obj.upload_url == "https://upload.example.com/obj_123"
-        mock_client.objects.create.assert_called_once()
+        mock_client.objects.create.assert_called_once_with(
+            name="test.txt",
+            content_type="text",
+            metadata={"key": "value"},
+        )
 
     def test_from_id(self, mock_client: Mock) -> None:
         """Test from_id method."""
@@ -231,7 +235,14 @@ def test_list(self, mock_client: Mock, object_view: MockObjectView) -> None:
         assert len(objects) == 1
         assert isinstance(objects[0], StorageObject)
         assert objects[0].id == "obj_123"
-        mock_client.objects.list.assert_called_once()
+        mock_client.objects.list.assert_called_once_with(
+            content_type="text",
+            limit=10,
+            name="test",
+            search="query",
+            starting_after="obj_000",
+            state="READ_ONLY",
+        )
 
     def test_upload_from_file(self, mock_client: Mock, object_view: MockObjectView, tmp_path: Path) -> None:
         """Test upload_from_file method."""
@@ -250,9 +261,14 @@ def test_upload_from_file(self, mock_client: Mock, object_view: MockObjectView,
 
         assert isinstance(obj, StorageObject)
         assert obj.id == "obj_123"
-        mock_client.objects.create.assert_called_once()
-        mock_client.objects.complete.assert_called_once()
+        mock_client.objects.create.assert_called_once_with(
+            name="test.txt",
+            content_type="text",
+            metadata=None,
+            ttl_ms=None,
+        )
         http_client.put.assert_called_once_with(object_view.upload_url, content=b"test content")
+        mock_client.objects.complete.assert_called_once()
 
     def test_upload_from_text(self, mock_client: Mock, object_view: MockObjectView) -> None:
         """Test upload_from_text method."""
@@ -272,6 +288,7 @@ def test_upload_from_text(self, mock_client: Mock, object_view: MockObjectView)
             name="test.txt",
             content_type="text",
             metadata={"key": "value"},
+            ttl_ms=None,
         )
         http_client.put.assert_called_once_with(object_view.upload_url, content="test content")
         mock_client.objects.complete.assert_called_once()
@@ -294,6 +311,7 @@ def test_upload_from_bytes(self, mock_client: Mock, object_view: MockObjectView)
             name="test.bin",
             content_type="binary",
             metadata=None,
+            ttl_ms=None,
         )
         http_client.put.assert_called_once_with(object_view.upload_url, content=b"test content")
         mock_client.objects.complete.assert_called_once()
@@ -362,10 +380,12 @@ def test_upload_from_dir_default_name(self, mock_client: Mock, object_view: Mock
 
         assert isinstance(obj, StorageObject)
         # Name should be directory name + .tar.gz
-        mock_client.objects.create.assert_called_once()
-        call_args = mock_client.objects.create.call_args
-        assert call_args[1]["name"] == "my_folder.tar.gz"
-        assert call_args[1]["content_type"] == "tgz"
+        mock_client.objects.create.assert_called_once_with(
+            name="my_folder.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
 
     def test_upload_from_dir_with_ttl(self, mock_client: Mock, object_view: MockObjectView, tmp_path: Path) -> None:
         """Test upload_from_dir with TTL."""
@@ -386,10 +406,12 @@ def test_upload_from_dir_with_ttl(self, mock_client: Mock, object_view: MockObje
         obj = client.upload_from_dir(test_dir, ttl=timedelta(hours=2))
 
         assert isinstance(obj, StorageObject)
-        mock_client.objects.create.assert_called_once()
-        call_args = mock_client.objects.create.call_args
-        # 2 hours = 7200 seconds = 7200000 milliseconds
-        assert call_args[1]["ttl_ms"] == 7200000
+        mock_client.objects.create.assert_called_once_with(
+            name="temp_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=7200000,  # 2 hours = 7200 seconds = 7200000 milliseconds
+        )
 
     def test_upload_from_dir_empty_directory(
         self, mock_client: Mock, object_view: MockObjectView, tmp_path: Path
@@ -410,7 +432,12 @@ def test_upload_from_dir_empty_directory(
 
         assert isinstance(obj, StorageObject)
         assert obj.id == "obj_123"
-        mock_client.objects.create.assert_called_once()
+        mock_client.objects.create.assert_called_once_with(
+            name="empty_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
         http_client.put.assert_called_once()
         mock_client.objects.complete.assert_called_once()
 
@@ -435,7 +462,14 @@ def test_upload_from_dir_with_string_path(
 
         assert isinstance(obj, StorageObject)
         assert obj.id == "obj_123"
-        mock_client.objects.create.assert_called_once()
+        mock_client.objects.create.assert_called_once_with(
+            name="string_path_dir.tar.gz",
+            content_type="tgz",
+            metadata=None,
+            ttl_ms=None,
+        )
+        http_client.put.assert_called_once()
+        mock_client.objects.complete.assert_called_once()
 
 
 class TestRunloopSDK: