make name first argument passed to scenario builder

Author: sid-rl

src/runloop_api_client/sdk/async_.py

@@ -801,7 +801,7 @@ def builder(self, name: str) -> AsyncScenarioBuilder:
         :return: A new AsyncScenarioBuilder instance
         :rtype: AsyncScenarioBuilder
         """
-        return AsyncScenarioBuilder(self._client, name)
+        return AsyncScenarioBuilder(name, self._client)
 
     def from_id(self, scenario_id: str) -> AsyncScenario:
         """Get an AsyncScenario instance for an existing scenario ID.

src/runloop_api_client/sdk/async_scenario_builder.py

@@ -41,13 +41,13 @@ class AsyncScenarioBuilder:
         >>> scenario = await builder.push()
     """
 
-    def __init__(self, client: AsyncRunloop, name: str) -> None:
+    def __init__(self, name: str, client: AsyncRunloop) -> None:
         """Initialize the builder.
 
-        :param client: AsyncRunloop client instance
-        :type client: AsyncRunloop
         :param name: Name for the scenario
         :type name: str
+        :param client: AsyncRunloop client instance
+        :type client: AsyncRunloop
         """
         self._client = client
         self._name = name

src/runloop_api_client/sdk/scenario_builder.py

@@ -41,13 +41,13 @@ class ScenarioBuilder:
         >>> scenario = builder.push()
     """
 
-    def __init__(self, client: Runloop, name: str) -> None:
+    def __init__(self, name: str, client: Runloop) -> None:
         """Initialize the builder.
 
-        :param client: Runloop client instance
-        :type client: Runloop
         :param name: Name for the scenario
         :type name: str
+        :param client: Runloop client instance
+        :type client: Runloop
         """
         self._client = client
         self._name = name

src/runloop_api_client/sdk/sync.py

@@ -822,7 +822,7 @@ def builder(self, name: str) -> ScenarioBuilder:
         :return: A new ScenarioBuilder instance
         :rtype: ScenarioBuilder
         """
-        return ScenarioBuilder(self._client, name)
+        return ScenarioBuilder(name, self._client)
 
     def from_id(self, scenario_id: str) -> Scenario:
         """Get a Scenario instance for an existing scenario ID.

tests/sdk/test_async_scenario_builder.py

@@ -36,11 +36,11 @@ def mock_snapshot(self, mock_async_client: MagicMock) -> AsyncSnapshot:
     @pytest.fixture
     def builder(self, mock_async_client: MagicMock) -> AsyncScenarioBuilder:
         """Create an AsyncScenarioBuilder instance with mock client."""
-        return AsyncScenarioBuilder(mock_async_client, "test-scenario")
+        return AsyncScenarioBuilder("test-scenario", mock_async_client)
 
     def test_instantiation(self, mock_async_client: MagicMock) -> None:
         """Test builder initialization and repr."""
-        builder = AsyncScenarioBuilder(mock_async_client, "my-scenario")
+        builder = AsyncScenarioBuilder("my-scenario", mock_async_client)
 
         assert builder._client is mock_async_client
         assert builder._name == "my-scenario"
@@ -136,7 +136,7 @@ def test_build_params_validation(self, builder: AsyncScenarioBuilder) -> None:
             builder._build_params()
 
         # Missing scorer (new builder)
-        builder2 = AsyncScenarioBuilder(builder._client, "test2")
+        builder2 = AsyncScenarioBuilder("test2", builder._client)
         builder2.with_problem_statement("Fix the bug")
         with pytest.raises(ValueError, match="At least one scorer is required"):
             builder2._build_params()

tests/sdk/test_scenario_builder.py

@@ -34,11 +34,11 @@ def mock_snapshot(self, mock_client: MagicMock) -> Snapshot:
     @pytest.fixture
     def builder(self, mock_client: MagicMock) -> ScenarioBuilder:
         """Create a ScenarioBuilder instance with mock client."""
-        return ScenarioBuilder(mock_client, "test-scenario")
+        return ScenarioBuilder("test-scenario", mock_client)
 
     def test_instantiation(self, mock_client: MagicMock) -> None:
         """Test builder initialization and repr."""
-        builder = ScenarioBuilder(mock_client, "my-scenario")
+        builder = ScenarioBuilder("my-scenario", mock_client)
 
         assert builder._client is mock_client
         assert builder._name == "my-scenario"
@@ -134,7 +134,7 @@ def test_build_params_validation(self, builder: ScenarioBuilder) -> None:
             builder._build_params()
 
         # Missing scorer (new builder)
-        builder2 = ScenarioBuilder(builder._client, "test2")
+        builder2 = ScenarioBuilder("test2", builder._client)
         builder2.with_problem_statement("Fix the bug")
         with pytest.raises(ValueError, match="At least one scorer is required"):
             builder2._build_params()