Skip to content

Commit 23f4f41

Browse files
committed
fixed tests to expect updated parameter/member names
1 parent 19f6645 commit 23f4f41

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

tests/sdk/async_devbox/test_interfaces.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
from tests.sdk.conftest import MockExecutionView
1616
from runloop_api_client.sdk import AsyncDevbox
17-
from runloop_api_client._types import NotGiven
17+
from runloop_api_client._types import NotGiven, Omit
1818

1919

2020
class TestAsyncCommandInterface:
@@ -34,7 +34,7 @@ async def test_exec_without_callbacks(
3434
assert await result.stdout() == "output"
3535
call_kwargs = mock_async_client.devboxes.execute_and_await_completion.call_args[1]
3636
assert call_kwargs["command"] == "echo hello"
37-
assert isinstance(call_kwargs["shell_name"], NotGiven) or call_kwargs["shell_name"] is None
37+
assert isinstance(call_kwargs["shell_name"], Omit)
3838
assert isinstance(call_kwargs["timeout"], NotGiven)
3939

4040
@pytest.mark.asyncio

tests/sdk/devbox/test_interfaces.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
from tests.sdk.conftest import MockExecutionView
1616
from runloop_api_client.sdk import Devbox
17-
from runloop_api_client._types import NotGiven
17+
from runloop_api_client._types import NotGiven, Omit
1818

1919

2020
class TestCommandInterface:
@@ -31,7 +31,7 @@ def test_exec_without_callbacks(self, mock_client: Mock, execution_view: MockExe
3131
assert result.stdout() == "output"
3232
call_kwargs = mock_client.devboxes.execute_and_await_completion.call_args[1]
3333
assert call_kwargs["command"] == "echo hello"
34-
assert isinstance(call_kwargs["shell_name"], NotGiven) or call_kwargs["shell_name"] is None
34+
assert isinstance(call_kwargs["shell_name"], Omit)
3535
assert call_kwargs["polling_config"] is None
3636
assert isinstance(call_kwargs["timeout"], NotGiven)
3737

tests/sdk/test_async_clients.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class TestAsyncSnapshotClient:
127127
@pytest.mark.asyncio
128128
async def test_list(self, mock_async_client: AsyncMock, snapshot_view: MockSnapshotView) -> None:
129129
"""Test list method."""
130-
page = SimpleNamespace(disk_snapshots=[snapshot_view])
130+
page = SimpleNamespace(snapshots=[snapshot_view])
131131
mock_async_client.devboxes.disk_snapshots.list = AsyncMock(return_value=page)
132132

133133
client = AsyncSnapshotClient(mock_async_client)

tests/sdk/test_clients.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ class TestSnapshotClient:
120120

121121
def test_list(self, mock_client: Mock, snapshot_view: MockSnapshotView) -> None:
122122
"""Test list method."""
123-
page = SimpleNamespace(disk_snapshots=[snapshot_view])
123+
page = SimpleNamespace(snapshots=[snapshot_view])
124124
mock_client.devboxes.disk_snapshots.list.return_value = page
125125

126126
client = SnapshotClient(mock_client)

0 commit comments

Comments
 (0)