address comments

Author: sid-rl

tests/smoketests/sdk/test_async_devbox.py

@@ -1041,6 +1041,23 @@ async def test_shell_exec_async_with_both_streams(self, devbox: AsyncDevbox) ->
 class TestAsyncDevboxLogs:
     """Test async devbox logs retrieval functionality."""
 
+    @pytest.mark.timeout(THIRTY_SECOND_TIMEOUT)
+    async def test_logs_basic(self, shared_devbox: AsyncDevbox) -> None:
+        """Test retrieving unfiltered devbox logs."""
+        test_message = "async basic log test message"
+        result = await shared_devbox.cmd.exec(f'echo "{test_message}"')
+        assert result.exit_code == 0
+
+        # Log ingestion is async — logs may not be queryable immediately after
+        # command execution. Poll every 1s with a 10s timeout (well within the
+        # 30s test timeout) to accommodate variable ingestion latency.
+        logs = await async_poll_until(
+            retriever=lambda: shared_devbox.logs(),
+            is_terminal=lambda l: any(test_message in (log.message or "") for log in l.logs),
+            config=PollingConfig(timeout_seconds=10, interval_seconds=1),
+        )
+        assert any(test_message in (log.message or "") for log in logs.logs)
+
     @pytest.mark.timeout(THIRTY_SECOND_TIMEOUT)
     async def test_logs_with_execution_filter(self, shared_devbox: AsyncDevbox) -> None:
         """Test retrieving devbox logs filtered by execution ID."""

tests/smoketests/sdk/test_devbox.py

@@ -1026,6 +1026,23 @@ def test_shell_exec_async_with_both_streams(self, devbox: Devbox) -> None:
 class TestDevboxLogs:
     """Test devbox logs retrieval functionality."""
 
+    @pytest.mark.timeout(THIRTY_SECOND_TIMEOUT)
+    def test_logs_basic(self, shared_devbox: Devbox) -> None:
+        """Test retrieving unfiltered devbox logs."""
+        test_message = "basic log test message"
+        result = shared_devbox.cmd.exec(f'echo "{test_message}"')
+        assert result.exit_code == 0
+
+        # Log ingestion is async — logs may not be queryable immediately after
+        # command execution. Poll every 1s with a 10s timeout (well within the
+        # 30s test timeout) to accommodate variable ingestion latency.
+        logs = poll_until(
+            retriever=lambda: shared_devbox.logs(),
+            is_terminal=lambda l: any(test_message in (log.message or "") for log in l.logs),
+            config=PollingConfig(timeout_seconds=10, interval_seconds=1),
+        )
+        assert any(test_message in (log.message or "") for log in logs.logs)
+
     @pytest.mark.timeout(THIRTY_SECOND_TIMEOUT)
     def test_logs_with_execution_filter(self, shared_devbox: Devbox) -> None:
         """Test retrieving devbox logs filtered by execution ID."""