rename _build_params to build (now publicly exposed method)

Author: sid-rl

src/runloop_api_client/sdk/async_scenario_builder.py

@@ -402,7 +402,7 @@ def _build_environment_params(self) -> Optional[ScenarioEnvironmentParam]:
             "working_directory": self._working_directory if self._working_directory else None,
         }
 
-    def _build_params(self) -> ScenarioCreateParams:
+    def build(self) -> ScenarioCreateParams:
         """Build the scenario creation parameters.
 
         Weights are automatically normalized to sum to 1.0.
@@ -473,6 +473,6 @@ async def push(self, **options: Unpack[LongRequestOptions]) -> AsyncScenario:
         :return: Created scenario wrapper
         :rtype: AsyncScenario
         """
-        params = self._build_params()
+        params = self.build()
         scenario_view = await self._client.scenarios.create(**params, **options)
         return AsyncScenario(self._client, scenario_view.id)

src/runloop_api_client/sdk/scenario_builder.py

@@ -402,7 +402,7 @@ def _build_environment_params(self) -> Optional[ScenarioEnvironmentParam]:
             "working_directory": self._working_directory if self._working_directory else None,
         }
 
-    def _build_params(self) -> ScenarioCreateParams:
+    def build(self) -> ScenarioCreateParams:
         """Build the scenario creation parameters.
 
         Weights are automatically normalized to sum to 1.0.
@@ -473,6 +473,6 @@ def push(self, **options: Unpack[LongRequestOptions]) -> Scenario:
         :return: Created scenario wrapper
         :rtype: Scenario
         """
-        params = self._build_params()
+        params = self.build()
         scenario_view = self._client.scenarios.create(**params, **options)
         return Scenario(self._client, scenario_view.id)

tests/sdk/test_async_scenario_builder.py

@@ -128,23 +128,23 @@ def test_add_scorer_rejects_invalid_weight(self, mock_builder: AsyncScenarioBuil
         with pytest.raises(ValueError, match="Scorer weight must be positive"):
             mock_builder.add_bash_script_scorer("bad", bash_script="echo 1", weight=-1.0)
 
-    def test_build_params_validation(self, mock_builder: AsyncScenarioBuilder) -> None:
-        """Test _build_params raises for missing required fields."""
+    def test_build_validation(self, mock_builder: AsyncScenarioBuilder) -> None:
+        """Test build raises for missing required fields."""
         # Missing problem statement
         mock_builder.add_test_command_scorer("test", test_command="pytest")
         with pytest.raises(ValueError, match="Problem statement is required"):
-            mock_builder._build_params()
+            mock_builder.build()
 
         # Missing scorer (new builder)
         builder2 = AsyncScenarioBuilder("test2", mock_builder._client)
         builder2.with_problem_statement("Fix the bug")
         with pytest.raises(ValueError, match="At least one scorer is required"):
-            builder2._build_params()
+            builder2.build()
 
-    def test_build_params_with_all_options(
+    def test_build_with_all_options(
         self, mock_builder: AsyncScenarioBuilder, mock_blueprint: AsyncBlueprint
     ) -> None:
-        """Test _build_params with all optional fields set."""
+        """Test build with all optional fields set."""
         mock_builder.with_problem_statement("Fix the bug")
         mock_builder.with_additional_context({"hint": "line 42"})
         mock_builder.add_test_command_scorer("tests", test_command="pytest")
@@ -156,7 +156,7 @@ def test_build_params_with_all_options(
         mock_builder.with_required_secrets(["db_pass"])
         mock_builder.with_validation_type("FORWARD")
 
-        params = mock_builder._build_params()
+        params = mock_builder.build()
 
         assert params["name"] == "test-scenario"
         assert params["input_context"]["problem_statement"] == "Fix the bug"
@@ -171,14 +171,14 @@ def test_build_params_with_all_options(
         assert params.get("required_secret_names") == ["db_pass"]
         assert params.get("validation_type") == "FORWARD"
 
-    def test_build_params_normalizes_weights(self, mock_builder: AsyncScenarioBuilder) -> None:
-        """Test that _build_params normalizes scorer weights to sum to 1.0."""
+    def test_build_normalizes_weights(self, mock_builder: AsyncScenarioBuilder) -> None:
+        """Test that build normalizes scorer weights to sum to 1.0."""
         mock_builder.with_problem_statement("Fix the bug")
         mock_builder.add_bash_script_scorer("scorer1", bash_script="echo 1", weight=1.0)
         mock_builder.add_bash_script_scorer("scorer2", bash_script="echo 2", weight=2.0)
         mock_builder.add_bash_script_scorer("scorer3", bash_script="echo 3", weight=3.0)
 
-        params = mock_builder._build_params()
+        params = mock_builder.build()
         scorers = list(params["scoring_contract"]["scoring_function_parameters"])
 
         # Weights 1, 2, 3 should normalize to 1/6, 2/6, 3/6

tests/sdk/test_scenario_builder.py

@@ -126,21 +126,21 @@ def test_add_scorer_rejects_invalid_weight(self, mock_builder: ScenarioBuilder)
         with pytest.raises(ValueError, match="Scorer weight must be positive"):
             mock_builder.add_bash_script_scorer("bad", bash_script="echo 1", weight=-1.0)
 
-    def test_build_params_validation(self, mock_builder: ScenarioBuilder) -> None:
-        """Test _build_params raises for missing required fields."""
+    def test_build_validation(self, mock_builder: ScenarioBuilder) -> None:
+        """Test build raises for missing required fields."""
         # Missing problem statement
         mock_builder.add_test_command_scorer("test", test_command="pytest")
         with pytest.raises(ValueError, match="Problem statement is required"):
-            mock_builder._build_params()
+            mock_builder.build()
 
         # Missing scorer (new builder)
         builder2 = ScenarioBuilder("test2", mock_builder._client)
         builder2.with_problem_statement("Fix the bug")
         with pytest.raises(ValueError, match="At least one scorer is required"):
-            builder2._build_params()
+            builder2.build()
 
-    def test_build_params_with_all_options(self, mock_builder: ScenarioBuilder, mock_blueprint: Blueprint) -> None:
-        """Test _build_params with all optional fields set."""
+    def test_build_with_all_options(self, mock_builder: ScenarioBuilder, mock_blueprint: Blueprint) -> None:
+        """Test build with all optional fields set."""
         mock_builder.with_problem_statement("Fix the bug")
         mock_builder.with_additional_context({"hint": "line 42"})
         mock_builder.add_test_command_scorer("tests", test_command="pytest")
@@ -152,7 +152,7 @@ def test_build_params_with_all_options(self, mock_builder: ScenarioBuilder, mock
         mock_builder.with_required_secrets(["db_pass"])
         mock_builder.with_validation_type("FORWARD")
 
-        params = mock_builder._build_params()
+        params = mock_builder.build()
 
         assert params["name"] == "test-scenario"
         assert params["input_context"]["problem_statement"] == "Fix the bug"
@@ -167,14 +167,14 @@ def test_build_params_with_all_options(self, mock_builder: ScenarioBuilder, mock
         assert params.get("required_secret_names") == ["db_pass"]
         assert params.get("validation_type") == "FORWARD"
 
-    def test_build_params_normalizes_weights(self, mock_builder: ScenarioBuilder) -> None:
-        """Test that _build_params normalizes scorer weights to sum to 1.0."""
+    def test_build_normalizes_weights(self, mock_builder: ScenarioBuilder) -> None:
+        """Test that build normalizes scorer weights to sum to 1.0."""
         mock_builder.with_problem_statement("Fix the bug")
         mock_builder.add_bash_script_scorer("scorer1", bash_script="echo 1", weight=1.0)
         mock_builder.add_bash_script_scorer("scorer2", bash_script="echo 2", weight=2.0)
         mock_builder.add_bash_script_scorer("scorer3", bash_script="echo 3", weight=3.0)
 
-        params = mock_builder._build_params()
+        params = mock_builder.build()
         scorers = list(params["scoring_contract"]["scoring_function_parameters"])
 
         # Weights 1, 2, 3 should normalize to 1/6, 2/6, 3/6

tests/smoketests/sdk/test_async_scenario.py

@@ -46,7 +46,7 @@ async def push_or_update_scenario(sdk_client: AsyncRunloopSDK, builder: AsyncSce
         new_snapshot_id = builder._snapshot.id if builder._snapshot else None
 
         # Update existing scenario with builder's params
-        params = builder._build_params()
+        params = builder.build()
         result = await scenario.update(**filter_params(params, SDKScenarioUpdateParams))
 
         # Delete OLD blueprint/snapshot if they're being replaced

tests/smoketests/sdk/test_scenario.py

@@ -45,7 +45,7 @@ def push_or_update_scenario(sdk_client: RunloopSDK, builder: ScenarioBuilder) ->
         new_snapshot_id = builder._snapshot.id if builder._snapshot else None
 
         # Update existing scenario with builder's params
-        params = builder._build_params()
+        params = builder.build()
         result = scenario.update(**filter_params(params, SDKScenarioUpdateParams))
 
         # Delete OLD blueprint/snapshot if they're being replaced