Remove unnecessary arguments for await_running, await_completed, create_and_await_running

Author: alb-rl

src/runloop_api_client/resources/devboxes/devboxes.py

@@ -360,13 +360,8 @@ def await_running(
         self,
         id: str,
         *,
+        # Use polling_config to configure the "long" polling behavior.
         polling_config: PollingConfig | None = None,
-        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
-        # The extra values given here take precedence over values defined on the client or passed to this method.
-        extra_headers: Headers | None = None,
-        extra_query: Query | None = None,
-        extra_body: Body | None = None,
-        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
     ) -> DevboxView:
         """Wait for a devbox to be in running state.
 
@@ -392,9 +387,6 @@ def wait_for_devbox_status() -> DevboxView:
             return self._post(
                 f"/v1/devboxes/{id}/wait_for_status",
                 body={"statuses": ["running", "failure"]},
-                options=make_request_options(
-                    extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
-                ),
                 cast_to=DevboxView,
             )
 
@@ -495,10 +487,6 @@ def create_and_await_running(
         return self.await_running(
             devbox.id,
             polling_config=polling_config,
-            extra_headers=extra_headers,
-            extra_query=extra_query,
-            extra_body=extra_body,
-            timeout=timeout,
         )
 
     def list(
@@ -1662,23 +1650,14 @@ async def create_and_await_running(
         return await self.await_running(
             devbox.id,
             polling_config=polling_config,
-            extra_headers=extra_headers,
-            extra_query=extra_query,
-            extra_body=extra_body,
-            timeout=timeout,
         )
 
     async def await_running(
         self,
         id: str,
         *,
+        # Use polling_config to configure the "long" polling behavior.
         polling_config: PollingConfig | None = None,
-        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
-        # The extra values given here take precedence over values defined on the client or passed to this method.
-        extra_headers: Headers | None = None,
-        extra_query: Query | None = None,
-        extra_body: Body | None = None,
-        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
     ) -> DevboxView:
         """Wait for a devbox to be in running state.
 
@@ -1705,9 +1684,6 @@ async def wait_for_devbox_status() -> DevboxView:
                 return await self._post(
                     f"/v1/devboxes/{id}/wait_for_status",
                     body={"statuses": ["running", "failure"]},
-                    options=make_request_options(
-                        extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
-                    ),
                     cast_to=DevboxView,
                 )
             except APIStatusError as error:

src/runloop_api_client/resources/devboxes/executions.py

@@ -97,13 +97,8 @@ def await_completed(
         execution_id: str,
         devbox_id: str,
         *,
-        config: PollingConfig | None = None,
-        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
-        # The extra values given here take precedence over values defined on the client or passed to this method.
-        extra_headers: Headers | None = None,
-        extra_query: Query | None = None,
-        extra_body: Body | None = None,
-        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
+        # Use polling_config to configure the "long" polling behavior.
+        polling_config: PollingConfig | None = None,
     ) -> DevboxAsyncExecutionDetailView:
         """Wait for an execution to complete.
 
@@ -128,9 +123,6 @@ def wait_for_execution_status() -> DevboxAsyncExecutionDetailView:
             return self._post(
                 f"/v1/devboxes/{devbox_id}/executions/{execution_id}/wait_for_status",
                 body={"statuses": ["completed"]},
-                options=make_request_options(
-                    extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
-                ),
                 cast_to=DevboxAsyncExecutionDetailView,
             )
 
@@ -152,7 +144,7 @@ def handle_timeout_error(error: Exception) -> DevboxAsyncExecutionDetailView:
         def is_done(execution: DevboxAsyncExecutionDetailView) -> bool:
             return execution.status == "completed"
 
-        return poll_until(wait_for_execution_status, is_done, config, handle_timeout_error)
+        return poll_until(wait_for_execution_status, is_done, polling_config, handle_timeout_error)
 
     def execute_async(
         self,
@@ -390,13 +382,8 @@ async def await_completed(
         execution_id: str,
         *,
         devbox_id: str,
+        # Use polling_config to configure the "long" polling behavior.
         polling_config: PollingConfig | None = None,
-        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
-        # The extra values given here take precedence over values defined on the client or passed to this method.
-        extra_headers: Headers | None = None,
-        extra_query: Query | None = None,
-        extra_body: Body | None = None,
-        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
     ) -> DevboxAsyncExecutionDetailView:
         """Wait for an execution to complete.
 
@@ -421,9 +408,6 @@ async def wait_for_execution_status() -> DevboxAsyncExecutionDetailView:
                 return await self._post(
                     f"/v1/devboxes/{devbox_id}/executions/{execution_id}/wait_for_status",
                     body={"statuses": ["completed"]},
-                    options=make_request_options(
-                        extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
-                    ),
                     cast_to=DevboxAsyncExecutionDetailView,
                 )
             except APIStatusError as error:

src/runloop_api_client/resources/scenarios/scenarios.py

@@ -471,10 +471,6 @@ def start_run_and_await_env_ready(
         self._client.devboxes.await_running(
             run.devbox_id,
             polling_config=polling_config,
-            extra_headers=extra_headers,
-            extra_query=extra_query,
-            extra_body=extra_body,
-            timeout=timeout,
         )
 
         return run

tests/api_resources/devboxes/test_executions.py

@@ -338,7 +338,7 @@ def test_method_await_completed_with_config(self, client: Runloop) -> None:
         with patch.object(client.devboxes.executions, "_post") as mock_post:
             mock_post.return_value = mock_execution_completed
 
-            result = client.devboxes.executions.await_completed("execution_id", "devbox_id", config=config)
+            result = client.devboxes.executions.await_completed("execution_id", "devbox_id", polling_config=config)
 
             assert result.execution_id == "execution_id"
             assert result.status == "completed"
@@ -361,7 +361,7 @@ def test_method_await_completed_polling_timeout(self, client: Runloop) -> None:
             mock_post.return_value = mock_execution_running
 
             with pytest.raises(PollingTimeout):
-                client.devboxes.executions.await_completed("execution_id", "devbox_id", config=config)
+                client.devboxes.executions.await_completed("execution_id", "devbox_id", polling_config=config)
 
     @parametrize
     def test_method_await_completed_various_statuses(self, client: Runloop) -> None: