Skip to content

Commit bf54da8

Browse files
committed
skip list_runs() smoketest when no available benchmark runs
1 parent 0f8c60f commit bf54da8

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

tests/smoketests/sdk/test_async_benchmark.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ async def test_list_runs(self, async_sdk_client: AsyncRunloopSDK) -> None:
137137
3. Validates returned objects are AsyncBenchmarkRun instances
138138
"""
139139
# Find an existing benchmark via raw API
140-
benchmarks_page = await async_sdk_client.api.benchmarks.list(limit=1)
140+
benchmarks_page = await async_sdk_client.api.benchmarks.list_public(limit=1)
141141
benchmarks = benchmarks_page.benchmarks
142142

143143
if not benchmarks:
@@ -151,9 +151,10 @@ async def test_list_runs(self, async_sdk_client: AsyncRunloopSDK) -> None:
151151
benchmark_id=benchmark_data.id,
152152
)
153153

154-
# List runs (might be empty, that's okay)
155154
runs = await benchmark.list_runs()
156155
assert isinstance(runs, list)
156+
if not runs:
157+
pytest.skip("No runs available to test")
157158

158159
# Verify returned items are AsyncBenchmarkRun objects
159160
for run in runs:

tests/smoketests/sdk/test_benchmark.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def test_list_runs(self, sdk_client: RunloopSDK) -> None:
133133
3. Validates returned objects are BenchmarkRun instances
134134
"""
135135
# Find an existing benchmark via raw API
136-
benchmarks = sdk_client.api.benchmarks.list(limit=1).benchmarks
136+
benchmarks = sdk_client.api.benchmarks.list_public(limit=1).benchmarks
137137

138138
if not benchmarks:
139139
raise Exception("No benchmarks available to test")
@@ -146,9 +146,10 @@ def test_list_runs(self, sdk_client: RunloopSDK) -> None:
146146
benchmark_id=benchmark_data.id,
147147
)
148148

149-
# List runs (might be empty, that's okay)
150149
runs = benchmark.list_runs()
151150
assert isinstance(runs, list)
151+
if not runs:
152+
pytest.skip("No runs available to test")
152153

153154
# Verify returned items are BenchmarkRun objects
154155
for run in runs:

0 commit comments

Comments
 (0)