Skip to content

Commit cc25e53

Browse files
committed
Fix types
1 parent 36058de commit cc25e53

5 files changed

Lines changed: 5 additions & 107 deletions

File tree

src/runloop_api_client/sdk/_types.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
DevboxListParams,
99
ObjectListParams,
1010
AgentCreateParams,
11+
DevboxCreateParams,
1112
ObjectCreateParams,
1213
ScenarioListParams,
1314
BenchmarkListParams,
@@ -86,6 +87,10 @@ class LongPollingRequestOptions(LongRequestOptions, PollingRequestOptions): # t
8687
pass
8788

8889

90+
class SDKDevboxCreateParams(DevboxCreateParams, LongPollingRequestOptions):
91+
pass
92+
93+
8994
class SDKDevboxCreateFromImageParams(DevboxBaseCreateParams, LongPollingRequestOptions):
9095
pass
9196

src/runloop_api_client/sdk/async_devbox.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from ..types import (
1212
DevboxView,
1313
TunnelView,
14-
DevboxTunnelView,
1514
DevboxExecutionDetailView,
1615
DevboxCreateSSHKeyResponse,
1716
)
@@ -23,7 +22,6 @@
2322
SDKDevboxExecuteParams,
2423
ExecuteStreamingCallbacks,
2524
SDKDevboxUploadFileParams,
26-
SDKDevboxCreateTunnelParams,
2725
SDKDevboxDownloadFileParams,
2826
SDKDevboxEnableTunnelParams,
2927
SDKDevboxExecuteAsyncParams,
@@ -807,34 +805,6 @@ async def create_ssh_key(
807805
**options,
808806
)
809807

810-
async def create_tunnel(
811-
self,
812-
**params: Unpack[SDKDevboxCreateTunnelParams],
813-
) -> DevboxTunnelView:
814-
"""[Deprecated] Create a legacy tunnel to expose a devbox port publicly.
815-
816-
Use :meth:`enable_tunnel` or configure a tunnel during devbox creation instead.
817-
818-
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxCreateTunnelParams` for available parameters
819-
:return: Details about the public endpoint
820-
:rtype: DevboxTunnelView
821-
822-
Example:
823-
>>> tunnel = await devbox.net.create_tunnel(port=8080)
824-
>>> print(f"Public URL: {tunnel.url}")
825-
"""
826-
warnings.warn(
827-
"create_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation.",
828-
DeprecationWarning,
829-
stacklevel=2,
830-
)
831-
with warnings.catch_warnings():
832-
warnings.simplefilter("ignore", DeprecationWarning)
833-
return await self._devbox._client.devboxes.create_tunnel( # type: ignore[deprecated]
834-
self._devbox.id,
835-
**params,
836-
)
837-
838808
async def enable_tunnel(
839809
self,
840810
**params: Unpack[SDKDevboxEnableTunnelParams],

src/runloop_api_client/sdk/devbox.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from ..types import (
1212
DevboxView,
1313
TunnelView,
14-
DevboxTunnelView,
1514
DevboxExecutionDetailView,
1615
DevboxCreateSSHKeyResponse,
1716
)
@@ -24,7 +23,6 @@
2423
ExecuteStreamingCallbacks,
2524
LongPollingRequestOptions,
2625
SDKDevboxUploadFileParams,
27-
SDKDevboxCreateTunnelParams,
2826
SDKDevboxDownloadFileParams,
2927
SDKDevboxEnableTunnelParams,
3028
SDKDevboxExecuteAsyncParams,
@@ -810,34 +808,6 @@ def create_ssh_key(
810808
**options,
811809
)
812810

813-
def create_tunnel(
814-
self,
815-
**params: Unpack[SDKDevboxCreateTunnelParams],
816-
) -> DevboxTunnelView:
817-
"""[Deprecated] Create a legacy tunnel to expose a devbox port publicly.
818-
819-
Use :meth:`enable_tunnel` or configure a tunnel during devbox creation instead.
820-
821-
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxCreateTunnelParams` for available parameters
822-
:return: Details about the public endpoint
823-
:rtype: :class:`~runloop_api_client.types.devbox_tunnel_view.DevboxTunnelView`
824-
825-
Example:
826-
>>> tunnel = devbox.net.create_tunnel(port=8080)
827-
>>> print(f"Public URL: {tunnel.url}")
828-
"""
829-
warnings.warn(
830-
"create_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation.",
831-
DeprecationWarning,
832-
stacklevel=2,
833-
)
834-
with warnings.catch_warnings():
835-
warnings.simplefilter("ignore", DeprecationWarning)
836-
return self._devbox._client.devboxes.create_tunnel( # type: ignore[deprecated]
837-
self._devbox.id,
838-
**params,
839-
)
840-
841811
def enable_tunnel(
842812
self,
843813
**params: Unpack[SDKDevboxEnableTunnelParams],

tests/sdk/async_devbox/test_interfaces.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -178,26 +178,6 @@ async def test_create_ssh_key(self, mock_async_client: AsyncMock) -> None:
178178
assert result == ssh_key_response
179179
mock_async_client.devboxes.create_ssh_key.assert_called_once()
180180

181-
@pytest.mark.asyncio
182-
async def test_create_tunnel(self, mock_async_client: AsyncMock) -> None:
183-
"""Test create tunnel."""
184-
tunnel_view = SimpleNamespace(tunnel_id="tunnel_123")
185-
mock_async_client.devboxes.create_tunnel = AsyncMock(return_value=tunnel_view)
186-
187-
devbox = AsyncDevbox(mock_async_client, "dbx_123")
188-
with pytest.warns(DeprecationWarning, match="create_tunnel is deprecated"):
189-
result = await devbox.net.create_tunnel(
190-
port=8080,
191-
extra_headers={"X-Custom": "value"},
192-
extra_query={"param": "value"},
193-
extra_body={"key": "value"},
194-
timeout=30.0,
195-
idempotency_key="key-123",
196-
)
197-
198-
assert result == tunnel_view
199-
mock_async_client.devboxes.create_tunnel.assert_called_once()
200-
201181
@pytest.mark.asyncio
202182
async def test_remove_tunnel(self, mock_async_client: AsyncMock) -> None:
203183
"""Test remove tunnel."""

tests/sdk/devbox/test_interfaces.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -280,33 +280,6 @@ def test_create_ssh_key(self, mock_client: Mock) -> None:
280280
idempotency_key="key-123",
281281
)
282282

283-
def test_create_tunnel(self, mock_client: Mock) -> None:
284-
"""Test create tunnel."""
285-
tunnel_view = SimpleNamespace(port=8080)
286-
mock_client.devboxes.create_tunnel.return_value = tunnel_view
287-
288-
devbox = Devbox(mock_client, "dbx_123")
289-
with pytest.warns(DeprecationWarning, match="create_tunnel is deprecated"):
290-
result = devbox.net.create_tunnel(
291-
port=8080,
292-
extra_headers={"X-Custom": "value"},
293-
extra_query={"param": "value"},
294-
extra_body={"key": "value"},
295-
timeout=30.0,
296-
idempotency_key="key-123",
297-
)
298-
299-
assert result == tunnel_view
300-
mock_client.devboxes.create_tunnel.assert_called_once_with(
301-
"dbx_123",
302-
port=8080,
303-
extra_headers={"X-Custom": "value"},
304-
extra_query={"param": "value"},
305-
extra_body={"key": "value"},
306-
timeout=30.0,
307-
idempotency_key="key-123",
308-
)
309-
310283
def test_remove_tunnel(self, mock_client: Mock) -> None:
311284
"""Test remove tunnel."""
312285
mock_client.devboxes.remove_tunnel.return_value = object()

0 commit comments

Comments
 (0)