Skip to content

Commit e3e2c14

Browse files
sid-rlsid-rl
committed
rename client to ops in client test
1 parent c5bc7d3 commit e3e2c14

2 files changed

Lines changed: 104 additions & 104 deletions

File tree

‎tests/sdk/test_async_clients.py‎

Lines changed: 52 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ async def test_create(self, mock_async_client: AsyncMock, devbox_view: MockDevbo
3838
"""Test create method."""
3939
mock_async_client.devboxes.create_and_await_running = AsyncMock(return_value=devbox_view)
4040

41-
client = AsyncDevboxOps(mock_async_client)
42-
devbox = await client.create(
41+
ops = AsyncDevboxOps(mock_async_client)
42+
devbox = await ops.create(
4343
name="test-devbox",
4444
metadata={"key": "value"},
4545
polling_config=PollingConfig(timeout_seconds=60.0),
@@ -54,8 +54,8 @@ async def test_create_from_blueprint_id(self, mock_async_client: AsyncMock, devb
5454
"""Test create_from_blueprint_id method."""
5555
mock_async_client.devboxes.create_and_await_running = AsyncMock(return_value=devbox_view)
5656

57-
client = AsyncDevboxOps(mock_async_client)
58-
devbox = await client.create_from_blueprint_id(
57+
ops = AsyncDevboxOps(mock_async_client)
58+
devbox = await ops.create_from_blueprint_id(
5959
"bp_123",
6060
name="test-devbox",
6161
)
@@ -69,8 +69,8 @@ async def test_create_from_blueprint_name(self, mock_async_client: AsyncMock, de
6969
"""Test create_from_blueprint_name method."""
7070
mock_async_client.devboxes.create_and_await_running = AsyncMock(return_value=devbox_view)
7171

72-
client = AsyncDevboxOps(mock_async_client)
73-
devbox = await client.create_from_blueprint_name(
72+
ops = AsyncDevboxOps(mock_async_client)
73+
devbox = await ops.create_from_blueprint_name(
7474
"my-blueprint",
7575
name="test-devbox",
7676
)
@@ -84,8 +84,8 @@ async def test_create_from_snapshot(self, mock_async_client: AsyncMock, devbox_v
8484
"""Test create_from_snapshot method."""
8585
mock_async_client.devboxes.create_and_await_running = AsyncMock(return_value=devbox_view)
8686

87-
client = AsyncDevboxOps(mock_async_client)
88-
devbox = await client.create_from_snapshot(
87+
ops = AsyncDevboxOps(mock_async_client)
88+
devbox = await ops.create_from_snapshot(
8989
"snap_123",
9090
name="test-devbox",
9191
)
@@ -96,8 +96,8 @@ async def test_create_from_snapshot(self, mock_async_client: AsyncMock, devbox_v
9696

9797
def test_from_id(self, mock_async_client: AsyncMock) -> None:
9898
"""Test from_id method."""
99-
client = AsyncDevboxOps(mock_async_client)
100-
devbox = client.from_id("dev_123")
99+
ops = AsyncDevboxOps(mock_async_client)
100+
devbox = ops.from_id("dev_123")
101101

102102
assert isinstance(devbox, AsyncDevbox)
103103
assert devbox.id == "dev_123"
@@ -111,8 +111,8 @@ async def test_list(self, mock_async_client: AsyncMock, devbox_view: MockDevboxV
111111
page = SimpleNamespace(devboxes=[devbox_view])
112112
mock_async_client.devboxes.list = AsyncMock(return_value=page)
113113

114-
client = AsyncDevboxOps(mock_async_client)
115-
devboxes = await client.list(
114+
ops = AsyncDevboxOps(mock_async_client)
115+
devboxes = await ops.list(
116116
limit=10,
117117
status="running",
118118
starting_after="dev_000",
@@ -133,8 +133,8 @@ async def test_list(self, mock_async_client: AsyncMock, snapshot_view: MockSnaps
133133
page = SimpleNamespace(snapshots=[snapshot_view])
134134
mock_async_client.devboxes.disk_snapshots.list = AsyncMock(return_value=page)
135135

136-
client = AsyncSnapshotOps(mock_async_client)
137-
snapshots = await client.list(
136+
ops = AsyncSnapshotOps(mock_async_client)
137+
snapshots = await ops.list(
138138
devbox_id="dev_123",
139139
limit=10,
140140
starting_after="snap_000",
@@ -147,8 +147,8 @@ async def test_list(self, mock_async_client: AsyncMock, snapshot_view: MockSnaps
147147

148148
def test_from_id(self, mock_async_client: AsyncMock) -> None:
149149
"""Test from_id method."""
150-
client = AsyncSnapshotOps(mock_async_client)
151-
snapshot = client.from_id("snap_123")
150+
ops = AsyncSnapshotOps(mock_async_client)
151+
snapshot = ops.from_id("snap_123")
152152

153153
assert isinstance(snapshot, AsyncSnapshot)
154154
assert snapshot.id == "snap_123"
@@ -162,8 +162,8 @@ async def test_create(self, mock_async_client: AsyncMock, blueprint_view: MockBl
162162
"""Test create method."""
163163
mock_async_client.blueprints.create_and_await_build_complete = AsyncMock(return_value=blueprint_view)
164164

165-
client = AsyncBlueprintOps(mock_async_client)
166-
blueprint = await client.create(
165+
ops = AsyncBlueprintOps(mock_async_client)
166+
blueprint = await ops.create(
167167
name="test-blueprint",
168168
polling_config=PollingConfig(timeout_seconds=60.0),
169169
)
@@ -174,8 +174,8 @@ async def test_create(self, mock_async_client: AsyncMock, blueprint_view: MockBl
174174

175175
def test_from_id(self, mock_async_client: AsyncMock) -> None:
176176
"""Test from_id method."""
177-
client = AsyncBlueprintOps(mock_async_client)
178-
blueprint = client.from_id("bp_123")
177+
ops = AsyncBlueprintOps(mock_async_client)
178+
blueprint = ops.from_id("bp_123")
179179

180180
assert isinstance(blueprint, AsyncBlueprint)
181181
assert blueprint.id == "bp_123"
@@ -186,8 +186,8 @@ async def test_list(self, mock_async_client: AsyncMock, blueprint_view: MockBlue
186186
page = SimpleNamespace(blueprints=[blueprint_view])
187187
mock_async_client.blueprints.list = AsyncMock(return_value=page)
188188

189-
client = AsyncBlueprintOps(mock_async_client)
190-
blueprints = await client.list(
189+
ops = AsyncBlueprintOps(mock_async_client)
190+
blueprints = await ops.list(
191191
limit=10,
192192
name="test",
193193
starting_after="bp_000",
@@ -207,8 +207,8 @@ async def test_create(self, mock_async_client: AsyncMock, object_view: MockObjec
207207
"""Test create method."""
208208
mock_async_client.objects.create = AsyncMock(return_value=object_view)
209209

210-
client = AsyncStorageObjectOps(mock_async_client)
211-
obj = await client.create(name="test.txt", content_type="text", metadata={"key": "value"})
210+
ops = AsyncStorageObjectOps(mock_async_client)
211+
obj = await ops.create(name="test.txt", content_type="text", metadata={"key": "value"})
212212

213213
assert isinstance(obj, AsyncStorageObject)
214214
assert obj.id == "obj_123"
@@ -221,8 +221,8 @@ async def test_create(self, mock_async_client: AsyncMock, object_view: MockObjec
221221

222222
def test_from_id(self, mock_async_client: AsyncMock) -> None:
223223
"""Test from_id method."""
224-
client = AsyncStorageObjectOps(mock_async_client)
225-
obj = client.from_id("obj_123")
224+
ops = AsyncStorageObjectOps(mock_async_client)
225+
obj = ops.from_id("obj_123")
226226

227227
assert isinstance(obj, AsyncStorageObject)
228228
assert obj.id == "obj_123"
@@ -234,8 +234,8 @@ async def test_list(self, mock_async_client: AsyncMock, object_view: MockObjectV
234234
page = SimpleNamespace(objects=[object_view])
235235
mock_async_client.objects.list = AsyncMock(return_value=page)
236236

237-
client = AsyncStorageObjectOps(mock_async_client)
238-
objects = await client.list(
237+
ops = AsyncStorageObjectOps(mock_async_client)
238+
objects = await ops.list(
239239
content_type="text",
240240
limit=10,
241241
name="test",
@@ -272,8 +272,8 @@ async def test_upload_from_file(
272272
http_client.put = AsyncMock(return_value=mock_response)
273273
mock_async_client._client = http_client
274274

275-
client = AsyncStorageObjectOps(mock_async_client)
276-
obj = await client.upload_from_file(temp_file, name="test.txt")
275+
ops = AsyncStorageObjectOps(mock_async_client)
276+
obj = await ops.upload_from_file(temp_file, name="test.txt")
277277

278278
assert isinstance(obj, AsyncStorageObject)
279279
assert obj.id == "obj_123"
@@ -297,8 +297,8 @@ async def test_upload_from_text(self, mock_async_client: AsyncMock, object_view:
297297
http_client.put = AsyncMock(return_value=mock_response)
298298
mock_async_client._client = http_client
299299

300-
client = AsyncStorageObjectOps(mock_async_client)
301-
obj = await client.upload_from_text("test content", name="test.txt", metadata={"key": "value"})
300+
ops = AsyncStorageObjectOps(mock_async_client)
301+
obj = await ops.upload_from_text("test content", name="test.txt", metadata={"key": "value"})
302302

303303
assert isinstance(obj, AsyncStorageObject)
304304
assert obj.id == "obj_123"
@@ -322,8 +322,8 @@ async def test_upload_from_bytes(self, mock_async_client: AsyncMock, object_view
322322
http_client.put = AsyncMock(return_value=mock_response)
323323
mock_async_client._client = http_client
324324

325-
client = AsyncStorageObjectOps(mock_async_client)
326-
obj = await client.upload_from_bytes(b"test content", name="test.bin", content_type="binary")
325+
ops = AsyncStorageObjectOps(mock_async_client)
326+
obj = await ops.upload_from_bytes(b"test content", name="test.bin", content_type="binary")
327327

328328
assert isinstance(obj, AsyncStorageObject)
329329
assert obj.id == "obj_123"
@@ -339,11 +339,11 @@ async def test_upload_from_bytes(self, mock_async_client: AsyncMock, object_view
339339
@pytest.mark.asyncio
340340
async def test_upload_from_file_missing_path(self, mock_async_client: AsyncMock, tmp_path: Path) -> None:
341341
"""upload_from_file should raise when file cannot be read."""
342-
client = AsyncStorageObjectOps(mock_async_client)
342+
ops = AsyncStorageObjectOps(mock_async_client)
343343
missing_file = tmp_path / "missing.txt"
344344

345345
with pytest.raises(OSError, match="Failed to read file"):
346-
await client.upload_from_file(missing_file)
346+
await ops.upload_from_file(missing_file)
347347

348348
@pytest.mark.asyncio
349349
async def test_upload_from_dir(
@@ -367,8 +367,8 @@ async def test_upload_from_dir(
367367
http_client.put = AsyncMock(return_value=mock_response)
368368
mock_async_client._client = http_client
369369

370-
client = AsyncStorageObjectOps(mock_async_client)
371-
obj = await client.upload_from_dir(test_dir, name="archive.tar.gz", metadata={"key": "value"})
370+
ops = AsyncStorageObjectOps(mock_async_client)
371+
obj = await ops.upload_from_dir(test_dir, name="archive.tar.gz", metadata={"key": "value"})
372372

373373
assert isinstance(obj, AsyncStorageObject)
374374
assert obj.id == "obj_123"
@@ -412,8 +412,8 @@ async def test_upload_from_dir_default_name(
412412
http_client.put = AsyncMock(return_value=mock_response)
413413
mock_async_client._client = http_client
414414

415-
client = AsyncStorageObjectOps(mock_async_client)
416-
obj = await client.upload_from_dir(test_dir)
415+
ops = AsyncStorageObjectOps(mock_async_client)
416+
obj = await ops.upload_from_dir(test_dir)
417417

418418
assert isinstance(obj, AsyncStorageObject)
419419
# Name should be directory name + .tar.gz
@@ -443,8 +443,8 @@ async def test_upload_from_dir_with_ttl(
443443
http_client.put = AsyncMock(return_value=mock_response)
444444
mock_async_client._client = http_client
445445

446-
client = AsyncStorageObjectOps(mock_async_client)
447-
obj = await client.upload_from_dir(test_dir, ttl=timedelta(hours=2))
446+
ops = AsyncStorageObjectOps(mock_async_client)
447+
obj = await ops.upload_from_dir(test_dir, ttl=timedelta(hours=2))
448448

449449
assert isinstance(obj, AsyncStorageObject)
450450
mock_async_client.objects.create.assert_awaited_once_with(
@@ -470,8 +470,8 @@ async def test_upload_from_dir_empty_directory(
470470
http_client.put = AsyncMock(return_value=mock_response)
471471
mock_async_client._client = http_client
472472

473-
client = AsyncStorageObjectOps(mock_async_client)
474-
obj = await client.upload_from_dir(test_dir)
473+
ops = AsyncStorageObjectOps(mock_async_client)
474+
obj = await ops.upload_from_dir(test_dir)
475475

476476
assert isinstance(obj, AsyncStorageObject)
477477
assert obj.id == "obj_123"
@@ -501,9 +501,9 @@ async def test_upload_from_dir_with_string_path(
501501
http_client.put = AsyncMock(return_value=mock_response)
502502
mock_async_client._client = http_client
503503

504-
client = AsyncStorageObjectOps(mock_async_client)
504+
ops = AsyncStorageObjectOps(mock_async_client)
505505
# Pass string path instead of Path object
506-
obj = await client.upload_from_dir(str(test_dir))
506+
obj = await ops.upload_from_dir(str(test_dir))
507507

508508
assert isinstance(obj, AsyncStorageObject)
509509
assert obj.id == "obj_123"
@@ -525,8 +525,8 @@ async def test_create(self, mock_async_client: AsyncMock, scorer_view: MockScore
525525
"""Test create method."""
526526
mock_async_client.scenarios.scorers.create = AsyncMock(return_value=scorer_view)
527527

528-
client = AsyncScorerOps(mock_async_client)
529-
scorer = await client.create(
528+
ops = AsyncScorerOps(mock_async_client)
529+
scorer = await ops.create(
530530
bash_script="echo 'score=1.0'",
531531
type="test_scorer",
532532
)
@@ -537,8 +537,8 @@ async def test_create(self, mock_async_client: AsyncMock, scorer_view: MockScore
537537

538538
def test_from_id(self, mock_async_client: AsyncMock) -> None:
539539
"""Test from_id method."""
540-
client = AsyncScorerOps(mock_async_client)
541-
scorer = client.from_id("scorer_123")
540+
ops = AsyncScorerOps(mock_async_client)
541+
scorer = ops.from_id("scorer_123")
542542

543543
assert isinstance(scorer, AsyncScorer)
544544
assert scorer.id == "scorer_123"
@@ -552,8 +552,8 @@ async def async_iter():
552552

553553
mock_async_client.scenarios.scorers.list = AsyncMock(return_value=async_iter())
554554

555-
client = AsyncScorerOps(mock_async_client)
556-
scorers = await client.list(
555+
ops = AsyncScorerOps(mock_async_client)
556+
scorers = await ops.list(
557557
limit=10,
558558
starting_after="scorer_000",
559559
)

0 commit comments

Comments
 (0)