Skip to content

Commit eab0b79

Browse files
committed
don't convert params from TypedDict to dict (unnecessary and undoes type hints)
1 parent b933abe commit eab0b79

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

src/runloop_api_client/sdk/async_devbox.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,6 @@ async def exec(
643643
>>> result = await shell.exec("npm install", stdout=lambda line: print(f"[LOG] {line}"))
644644
"""
645645
# Ensure shell_name is set and cannot be overridden by user params
646-
params = dict(params)
647646
params["shell_name"] = self._shell_name
648647
return await self._devbox.cmd.exec(command, **params)
649648

@@ -677,7 +676,6 @@ async def exec_async(
677676
... print("Task completed successfully!")
678677
"""
679678
# Ensure shell_name is set and cannot be overridden by user params
680-
params = dict(params)
681679
params["shell_name"] = self._shell_name
682680
return await self._devbox.cmd.exec_async(command, **params)
683681

src/runloop_api_client/sdk/devbox.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,6 @@ def exec(
651651
>>> result = shell.exec("npm install", stdout=lambda line: print(f"[LOG] {line}"))
652652
"""
653653
# Ensure shell_name is set and cannot be overridden by user params
654-
params = dict(params)
655654
params["shell_name"] = self._shell_name
656655
return self._devbox.cmd.exec(command, **params)
657656

@@ -685,7 +684,6 @@ def exec_async(
685684
... print("Task completed successfully!")
686685
"""
687686
# Ensure shell_name is set and cannot be overridden by user params
688-
params = dict(params)
689687
params["shell_name"] = self._shell_name
690688
return self._devbox.cmd.exec_async(command, **params)
691689

0 commit comments

Comments
 (0)