-
Notifications
You must be signed in to change notification settings - Fork 2
file_mount validation limits for python client #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
48a3c0f
61c00ca
cccf210
5266abb
640c4e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import List, Optional | ||
|
|
||
|
|
||
| class ValidationNotification: | ||
| """Collects validation errors without raising exceptions. | ||
|
|
||
| This follows the notification pattern: validations append errors, and callers | ||
| decide how to react (e.g., surface all messages at once or abort). | ||
| """ | ||
|
|
||
| def __init__(self) -> None: | ||
| self._errors: List[str] = [] | ||
| self._causes: List[Optional[Exception]] = [] | ||
|
|
||
| def add_error(self, message: str, cause: Optional[Exception] = None) -> None: | ||
| self._errors.append(message) | ||
| self._causes.append(cause) | ||
|
|
||
| def has_errors(self) -> bool: | ||
| return len(self._errors) > 0 | ||
|
|
||
| @property | ||
| def errors(self) -> List[str]: | ||
| # Return a copy to avoid external mutation | ||
| return list(self._errors) | ||
|
|
||
| def error_message(self) -> str: | ||
| # Join with semicolons to present multiple issues succinctly | ||
| return "; ".join(self._errors) |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be a good idea to test that we don't reject file mounts when under or precisely at the limit
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are just client-side validations. There's no point being hyper-precise about these limits since they're really enforced on the server side anyway -- there's nothing to stop a caller ignoring our client & using our API endpoints directly.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense! |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep these limits static or adjust them based on Devbox resource allocation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This limit isn't a devbox limitation; it's a blueprint dockerfile length constraint. I think that each
file_mountperforms a text substitution inside the dockerfile, so the problem is that the dockerfile becomes too massive; not that the file_mounts exhaust resources for the devbox the dockerfile gets compiled onThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense!