Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/runloop_api_client/sdk/async_devbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import asyncio
import logging
import warnings

from typing import TYPE_CHECKING, Any, Callable, Optional, Sequence, Awaitable, cast
from typing_extensions import Unpack, override

Expand Down Expand Up @@ -835,7 +835,7 @@ async def remove_tunnel(
self,
**params: Unpack[SDKDevboxRemoveTunnelParams],
) -> object:
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
"""Remove a tunnel from the devbox.

:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
:return: Response confirming the tunnel removal
Expand All @@ -844,14 +844,7 @@ async def remove_tunnel(
Example:
>>> await devbox.net.remove_tunnel()
"""
warnings.warn(
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
DeprecationWarning,
stacklevel=2,
return await self._devbox._client.devboxes.remove_tunnel(
self._devbox.id,
**params,
)
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
return await self._devbox._client.devboxes.remove_tunnel( # type: ignore[deprecated]
self._devbox.id,
**params,
)
17 changes: 5 additions & 12 deletions src/runloop_api_client/sdk/devbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

import logging
import warnings

import threading
from typing import TYPE_CHECKING, Any, Callable, Optional, Sequence
from typing_extensions import Unpack, override
Expand Down Expand Up @@ -838,7 +838,7 @@ def remove_tunnel(
self,
**params: Unpack[SDKDevboxRemoveTunnelParams],
) -> object:
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
"""Remove a tunnel from the devbox.

:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
:return: Response confirming the tunnel removal
Expand All @@ -847,14 +847,7 @@ def remove_tunnel(
Example:
>>> devbox.net.remove_tunnel()
"""
warnings.warn(
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
DeprecationWarning,
stacklevel=2,
return self._devbox._client.devboxes.remove_tunnel(
self._devbox.id,
**params,
)
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
return self._devbox._client.devboxes.remove_tunnel( # type: ignore[deprecated]
self._devbox.id,
**params,
)
15 changes: 7 additions & 8 deletions tests/sdk/async_devbox/test_interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,13 @@ async def test_remove_tunnel(self, mock_async_client: AsyncMock) -> None:
mock_async_client.devboxes.remove_tunnel = AsyncMock(return_value=object())

devbox = AsyncDevbox(mock_async_client, "dbx_123")
with pytest.warns(DeprecationWarning, match="remove_tunnel is deprecated"):
result = await devbox.net.remove_tunnel(
extra_headers={"X-Custom": "value"},
extra_query={"param": "value"},
extra_body={"key": "value"},
timeout=30.0,
idempotency_key="key-123",
)
result = await devbox.net.remove_tunnel(
extra_headers={"X-Custom": "value"},
extra_query={"param": "value"},
extra_body={"key": "value"},
timeout=30.0,
idempotency_key="key-123",
)

assert result is not None # Verify return value is propagated
mock_async_client.devboxes.remove_tunnel.assert_called_once()
15 changes: 7 additions & 8 deletions tests/sdk/devbox/test_interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,13 @@ def test_remove_tunnel(self, mock_client: Mock) -> None:
mock_client.devboxes.remove_tunnel.return_value = object()

devbox = Devbox(mock_client, "dbx_123")
with pytest.warns(DeprecationWarning, match="remove_tunnel is deprecated"):
result = devbox.net.remove_tunnel(
extra_headers={"X-Custom": "value"},
extra_query={"param": "value"},
extra_body={"key": "value"},
timeout=30.0,
idempotency_key="key-123",
)
result = devbox.net.remove_tunnel(
extra_headers={"X-Custom": "value"},
extra_query={"param": "value"},
extra_body={"key": "value"},
timeout=30.0,
idempotency_key="key-123",
)

assert result is not None # Verify return value is propagated
mock_client.devboxes.remove_tunnel.assert_called_once_with(
Expand Down
Loading