Commit 31661f3
fix(h2-transport): address review nits (unreachable 101, url descriptor, stale comment)
Per review on #815:
- Drop `101` from NULL_BODY_STATUSES — Switching Protocols is an HTTP/1.1
upgrade status and can't occur over HTTP/2, so it was unreachable.
- Add `writable: true` to the `Response.url` property descriptor.
- Fix a stale comment in tests/index.test.ts that referenced the pre-refactor
`useHttp2` / `makeHttp2Fetch(...)` shape; it's now `resolveHttp2Fetch(options)`.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent f37c3c5 commit 31661f3
2 files changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
87 | | - | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
0 commit comments