cp dines

Author: dines-rl

src/sdk/scorer.ts

@@ -6,8 +6,6 @@ import type {
   ScorerRetrieveResponse,
   ScorerUpdateResponse,
   ScorerUpdateParams,
-  ScorerValidateParams,
-  ScorerValidateResponse,
 } from '../resources/scenarios/scorers';
 
 /**
@@ -32,8 +30,8 @@ import type {
  *   bash_script: 'echo "1.0"',
  * });
  *
- * const result = await scorer.validate({ scoring_context: { output: 'test' } });
- * console.log(`Score: ${result.scoring_result.score}`);
+ * const info = await scorer.getInfo();
+ * console.log(`Scorer type: ${info.type}`);
  * ```
  */
 export class Scorer {
@@ -177,26 +175,4 @@ export class Scorer {
     return this.client.scenarios.scorers.update(this._id, params, options);
   }
 
-  /**
-   * Run the scorer against the provided context and return the result.
-   *
-   * @example
-   * ```typescript
-   * const result = await scorer.validate({
-   *   scoring_context: { output: 'test output', expected: 'test output' }
-   * });
-   * console.log(`Validation score: ${result.scoring_result.score}`);
-   * console.log(`Output: ${result.scoring_result.output}`);
-   * ```
-   *
-   * @param {ScorerValidateParams} params - Validation parameters
-   * @param {Core.RequestOptions} [options] - Request options
-   * @returns {Promise<ScorerValidateResponse>} Validation result with score
-   */
-  async validate(
-    params: ScorerValidateParams,
-    options?: Core.RequestOptions,
-  ): Promise<ScorerValidateResponse> {
-    return this.client.scenarios.scorers.validate(this._id, params, options);
-  }
 }

tests/objects/scorer.test.ts

@@ -2,7 +2,6 @@ import { Scorer } from '../../src/sdk/scorer';
 import type {
   ScorerRetrieveResponse,
   ScorerUpdateResponse,
-  ScorerValidateResponse,
 } from '../../src/resources/scenarios/scorers';
 
 // Mock the Runloop client
@@ -11,7 +10,6 @@ jest.mock('../../src/index');
 describe('Scorer', () => {
   let mockClient: any;
   let mockScorerData: ScorerRetrieveResponse;
-  let mockValidateResult: ScorerValidateResponse;
 
   beforeEach(() => {
     mockClient = {
@@ -20,7 +18,6 @@ describe('Scorer', () => {
           create: jest.fn(),
           retrieve: jest.fn(),
           update: jest.fn(),
-          validate: jest.fn(),
           list: jest.fn(),
         },
       },
@@ -32,16 +29,6 @@ describe('Scorer', () => {
       bash_script: 'echo "1.0"',
     };
 
-    mockValidateResult = {
-      name: 'my_custom_scorer',
-      scoring_context: { output: 'test' },
-      scoring_result: {
-        output: '1.0',
-        score: 1.0,
-        state: 'complete',
-        scoring_function_name: 'test-scorer',
-      },
-    };
   });
 
   describe('fromId', () => {
@@ -188,38 +175,6 @@ describe('Scorer', () => {
     });
   });
 
-  describe('validate', () => {
-    it('should validate scorer with scoring context', async () => {
-      mockClient.scenarios.scorers.validate.mockResolvedValue(mockValidateResult);
-
-      const scorer = Scorer.fromId(mockClient, 'scs_123');
-      const result = await scorer.validate({
-        scoring_context: { output: 'test output', expected: 'expected output' },
-      });
-
-      expect(mockClient.scenarios.scorers.validate).toHaveBeenCalledWith(
-        'scs_123',
-        { scoring_context: { output: 'test output', expected: 'expected output' } },
-        undefined,
-      );
-      expect(result.scoring_result.score).toBe(1.0);
-      expect(result.scoring_result.output).toBe('1.0');
-    });
-
-    it('should pass options to the API client', async () => {
-      mockClient.scenarios.scorers.validate.mockResolvedValue(mockValidateResult);
-
-      const scorer = Scorer.fromId(mockClient, 'scs_123');
-      await scorer.validate({ scoring_context: {} }, { timeout: 30000 });
-
-      expect(mockClient.scenarios.scorers.validate).toHaveBeenCalledWith(
-        'scs_123',
-        { scoring_context: {} },
-        { timeout: 30000 },
-      );
-    });
-  });
-
   describe('error handling', () => {
     it('should handle API errors on getInfo', async () => {
       const error = new Error('Scorer not found');
@@ -241,13 +196,5 @@ describe('Scorer', () => {
       );
     });
 
-    it('should handle API errors on validate', async () => {
-      const error = new Error('Validation timeout');
-      mockClient.scenarios.scorers.validate.mockRejectedValue(error);
-
-      const scorer = Scorer.fromId(mockClient, 'scs_123');
-
-      await expect(scorer.validate({ scoring_context: {} })).rejects.toThrow('Validation timeout');
-    });
   });
 });