feat(devbox): added suspend async and promoted suspend to automatically await the devbox running - #670
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:M
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
|
||
| // Status might still be suspended or transitioning | ||
| const infoAfterResume = await devbox.getInfo(); | ||
| expect(['suspended', 'running', 'starting']).toContain(infoAfterResume.status); |
There was a problem hiding this comment.
Suggestion: The status assertion in the new resumeAsync test ignores the real resuming state that the API returns immediately after calling resumeAsync, so whenever the devbox is in that legitimate state the test will fail because infoAfterResume.status will not be in the hard‑coded list. [logic error]
Severity Level: Minor
| expect(['suspended', 'running', 'starting']).toContain(infoAfterResume.status); | |
| expect(['suspended', 'resuming', 'running']).toContain(infoAfterResume.status); |
Why it matters? ⭐
The SDK's Devbox status enum actually includes resuming (and not starting), so the current assertion flakes whenever the API reports the legitimate resuming state immediately after resumeAsync. Expanding the allowed values to include resuming fixes that real test failure.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** tests/smoketests/object-oriented/devbox.test.ts
**Line:** 166:166
**Comment:**
*Logic Error: The status assertion in the new `resumeAsync` test ignores the real `resuming` state that the API returns immediately after calling `resumeAsync`, so whenever the devbox is in that legitimate state the test will fail because `infoAfterResume.status` will not be in the hard‑coded list.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
|
CodeAnt AI finished reviewing your PR. |
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 93.1% | 100% | ❌ |
| Lines | 83.11% | - | ℹ️ |
| Branches | 51.02% | - | ℹ️ |
| Statements | 82.73% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 94.82% | 100% | ❌ |
| Lines | 84.16% | - | ℹ️ |
| Branches | 51.02% | - | ℹ️ |
| Statements | 83.76% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 99.13% | 100% | ❌ |
| Lines | 86.27% | - | ℹ️ |
| Branches | 51.02% | - | ℹ️ |
| Statements | 85.82% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 98.27% | 100% | ❌ |
| Lines | 85.48% | - | ℹ️ |
| Branches | 51.02% | - | ℹ️ |
| Statements | 85.05% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
3 participants
CodeAnt-AI Description
Resume devbox waits for running state and adds resumeAsync
What Changed
resume()now returns the devbox view once it reaches the running state, so callers automatically know when the machine is available.resumeAsync()for clients that want to trigger a resume without waiting, with an explicit follow-up call to check running status.Impact
✅ Immediate running confirmation after resume✅ Explicit resume option without waiting✅ Verified resume timing in smoke tests💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.