Skip to content

ci: fix test with invalid limit specification#724

Merged
dines-rl merged 1 commit into
mainfrom
dines/fix-smoke-gateway-test
Feb 25, 2026
Merged

ci: fix test with invalid limit specification#724
dines-rl merged 1 commit into
mainfrom
dines/fix-smoke-gateway-test

Conversation

@dines-rl

@dines-rl dines-rl commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

User description

⚠️ PR Title Must Follow Conventional Commits

Format: feat[optional scope]: <description>

Examples: feat: add new SDK method · feat(storage): support file uploads · feat!: breaking API change


Description

Motivation

Changes

Testing

  • Unit tests added
  • Integration tests added
  • Smoke Tests added/updated
  • Tested locally

Breaking Changes

Checklist

  • PR title follows Conventional Commits format (feat: or feat(scope):)
  • Documentation updated (if needed)
  • Breaking changes documented (if applicable)

CodeAnt-AI Description

Fix smoketest that used an invalid API parameter causing intermittent failures

What Changed

  • Updated the gateway smoke test to request /v1/devboxes?limit=1 instead of limit=0 because the API requires limit > 0
  • Added an inline comment explaining the reason for the minimal response value to prevent future regressions

Impact

✅ Fewer CI test failures
✅ Shorter test debugging for gateway smoke tests
✅ Reliable minimal-response verification in smoketests

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai

codeant-ai Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@dines-rl
dines-rl requested review from adam-rl and alb-rl February 25, 2026 00:53
@dines-rl
dines-rl enabled auto-merge (squash) February 25, 2026 00:53
@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Feb 25, 2026
@codeant-ai

codeant-ai Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Possible Parse Error
    The test calls JSON.parse(responseBody) after making the request. If the gateway returns an empty body (e.g. 204 No Content) or non-JSON payload, JSON.parse will throw and fail the test. Guarding against empty/non-JSON bodies or checking status codes before parsing will make the test more robust.

@codeant-ai

codeant-ai Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI finished reviewing your PR.

@dines-rl
dines-rl merged commit daae454 into main Feb 25, 2026
9 checks passed
@dines-rl
dines-rl deleted the dines/fix-smoke-gateway-test branch February 25, 2026 01:00
@github-actions

Copy link
Copy Markdown

⚠️ Object Smoke Tests & Coverage Report

Test Results

✅ All smoke tests passed

Coverage Results

Metric Coverage Required Status
Functions 97.97% 100%
Lines 86.79% - ℹ️
Branches 65.75% - ℹ️
Statements 85.48% - ℹ️

Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)

⚠️ Some object methods are not covered in smoke tests. Please add tests that call all public methods.

View detailed coverage report
File Functions Lines Branches
src/sdk.ts ❌ 96.15% 82.05% 70.83%
src/sdk/agent.ts ✅ 100% 100% 100%
src/sdk/blueprint.ts ✅ 100% 100% 80%
src/sdk/devbox.ts ✅ 100% 91.81% 96.96%
src/sdk/execution-result.ts ✅ 100% 92.68% 70.83%
src/sdk/execution.ts ✅ 100% 94.11% 83.33%
src/sdk/gateway-config.ts ✅ 100% 100% 100%
src/sdk/network-policy.ts ✅ 100% 100% 100%
src/sdk/scenario-run.ts ❌ 92.85% 75% 50%
src/sdk/scenario.ts ❌ 85.71% 91.66% 100%
src/sdk/scorer.ts ✅ 100% 100% 100%
src/sdk/snapshot.ts ✅ 100% 100% 100%
src/sdk/storage-object.ts ✅ 100% 80% 48.93%

📋 View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants