-
Notifications
You must be signed in to change notification settings - Fork 3
fix: add logs to devboxes, smoke tests & examples #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,12 +26,12 @@ const sdk = new RunloopSDK({ | |
| // Create a new devbox and wait for it to be ready | ||
| const devbox = await sdk.devbox.create(); | ||
|
|
||
| // Execute a synchronous command | ||
| // Execute a command that returns immediately - exec blocks until completion | ||
| const result = await devbox.cmd.exec('echo "Hello, World!"'); | ||
| console.log('Output:', await result.stdout()); // "Hello, World!" | ||
| console.log('Exit code:', result.exitCode); // 0 | ||
|
|
||
| // Start a long-running HTTP server asynchronously | ||
| // Start a long-running HTTP server - execAsync returns immediately | ||
| const serverExec = await devbox.cmd.execAsync('npx http-server -p 8080'); | ||
| console.log(`Started server with execution ID: ${serverExec.executionId}`); | ||
|
|
||
|
|
@@ -42,6 +42,10 @@ console.log('Server status:', state.status); // "running" | |
| // Later... kill the server when done | ||
| await serverExec.kill(); | ||
|
|
||
| // Retrieve devbox logs | ||
| const logs = await devbox.logs(); | ||
| console.log('Devbox logs:', logs.logs); | ||
|
|
||
| await devbox.shutdown(); | ||
| ``` | ||
|
|
||
|
|
@@ -85,6 +89,25 @@ The SDK provides object-oriented interfaces for all major Runloop resources: | |
|
|
||
| The SDK is fully typed with comprehensive TypeScript definitions: | ||
|
|
||
| ### Devbox Logs | ||
|
|
||
| Retrieve logs from a devbox, optionally filtered by execution ID or shell name: | ||
|
|
||
| ```typescript | ||
| const devbox = await runloop.devbox.create(); | ||
|
|
||
| // Get all devbox logs | ||
| const logs = await devbox.logs(); | ||
| console.log(logs.logs); | ||
|
|
||
| // Filter logs by execution ID | ||
| const result = await devbox.cmd.exec('echo "hello"'); | ||
| const execLogs = await devbox.logs({ execution_id: result.executionId }); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this the smae as getting the asyncExecResult.logs? |
||
|
|
||
| // Filter logs by shell name | ||
| const shellLogs = await devbox.logs({ shell_name: 'my-shell' }); | ||
| ``` | ||
|
|
||
| ### Blueprints | ||
|
|
||
| Blueprints define reusable devbox configurations. Create blueprints via `runloop.blueprint.create()` and access build logs with `blueprint.logs()`: | ||
|
|
@@ -341,6 +364,17 @@ The following runtimes are supported: | |
|
|
||
| If you are interested in other runtime environments, please open or upvote an issue on GitHub. | ||
|
|
||
| ## Development | ||
|
|
||
| After cloning the repository, run the bootstrap script and install git hooks: | ||
|
|
||
| ```sh | ||
| ./scripts/bootstrap | ||
| ./scripts/install-hooks | ||
| ``` | ||
|
|
||
| This installs pre-push hooks that run linting and verify generated files are up to date. | ||
|
|
||
| ## Contributing | ||
|
|
||
| See [the contributing documentation](./CONTRIBUTING.md). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -e | ||
|
|
||
| cd "$(dirname "$0")/.." | ||
|
|
||
| echo "==> Installing git hooks..." | ||
|
|
||
| mkdir -p .git/hooks | ||
|
|
||
| cat > .git/hooks/pre-push << 'EOF' | ||
| #!/usr/bin/env bash | ||
| set -e | ||
| cd "$(git rev-parse --show-toplevel)" | ||
|
|
||
| echo "==> Running lint checks..." | ||
| ./scripts/lint | ||
|
|
||
| echo "==> Checking EXAMPLES.md is up to date..." | ||
| yarn check:examples-md | ||
|
|
||
| echo "==> All checks passed!" | ||
| EOF | ||
|
|
||
| chmod +x .git/hooks/pre-push | ||
|
|
||
| echo "==> Git hooks installed successfully!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this all like executions too?