Replace createTunnel with enableTunnel in smoketests#746
Merged
Conversation
- Updated devbox smoketests to use enableTunnel instead of createTunnel - Updated test descriptions to reflect the new method name - All references to createTunnel in smoketests have been replaced Co-authored-by: albert <alb-rl@users.noreply.github.com>
- Remove port parameter from enableTunnel() calls - Update assertions to match V2 tunnel response structure (tunnel_key, create_time_ms) - Remove old V1 tunnel assertions (devbox_id, port, url) - Update test descriptions to be more accurate Co-authored-by: albert <alb-rl@users.noreply.github.com>
- Removed 'enable V2 tunnel (legacy test)' test - Removed 'remove tunnel after enable (should fail)' test - These tests were using the old createTunnel API which has been replaced Co-authored-by: albert <alb-rl@users.noreply.github.com>
alb-rl
marked this pull request as ready for review
March 18, 2026 21:43
❌ Object Smoke Tests FailedTest Results❌ Some smoke tests failed Failed Tests:
Please fix the failing tests before checking coverage. |
james-rl
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes legacy smoketests that were using the deprecated
createTunnelendpoint.Changes
tests/smoketests/object-oriented/devbox.test.ts:enable V2 tunnel (legacy test)testremove tunnel after enable (should fail)testcreateTunnelAPI which has been replaced withenableTunnelDetails
The deleted tests were testing deprecated functionality. The remaining tests in the file already cover the new
enableTunnelendpoint properly with correct V2 tunnel assertions.Slack Thread
Slack Thread