fix: bug with detail page stale data (#120)

Author: dines-rl

src/components/ResourceDetailPage.tsx

@@ -57,6 +57,7 @@ export function ResourceDetailPage<T>({
   buildDetailLines,
   additionalContent,
   pollResource,
+  onPollUpdate,
   pollInterval = 3000,
 }: ResourceDetailPageProps<T>) {
   const isMounted = React.useRef(true);
@@ -74,6 +75,11 @@ export function ResourceDetailPage<T>({
   const [currentResource, setCurrentResource] = React.useState(initialResource);
   const [copyStatus, setCopyStatus] = React.useState<string | null>(null);
 
+  // Keep local resource in sync when parent provides fresher data.
+  React.useEffect(() => {
+    setCurrentResource(initialResource);
+  }, [initialResource]);
+
   // Copy to clipboard with status feedback
   const handleCopy = React.useCallback(async (text: string) => {
     const status = await copyToClipboard(text);
@@ -114,6 +120,7 @@ export function ResourceDetailPage<T>({
           const updatedResource = await pollResource();
           if (isMounted.current) {
             setCurrentResource(updatedResource);
+            onPollUpdate?.(updatedResource);
           }
         } catch {
           // Silently ignore polling errors
@@ -122,7 +129,7 @@ export function ResourceDetailPage<T>({
     }, pollInterval);
 
     return () => clearInterval(interval);
-  }, [pollResource, pollInterval, showDetailedInfo]);
+  }, [pollResource, pollInterval, showDetailedInfo, onPollUpdate]);
 
   // Calculate viewport for detailed info view
   const detailViewport = useViewportHeight({ overhead: 18, minHeight: 10 });

src/components/resourceDetailTypes.ts

@@ -113,6 +113,8 @@ export interface ResourceDetailPageProps<T> {
   additionalContent?: React.ReactNode;
   /** Optional: Polling function to refresh resource data */
   pollResource?: () => Promise<T>;
+  /** Optional: Called whenever polling returns a fresh resource */
+  onPollUpdate?: (resource: T) => void;
   /** Polling interval in ms (default: 3000) */
   pollInterval?: number;
 }

src/screens/BenchmarkJobDetailScreen.tsx

@@ -946,6 +946,7 @@ export function BenchmarkJobDetailScreen({
       onBack={goBack}
       buildDetailLines={buildDetailLines}
       pollResource={isRunning ? pollJob : undefined}
+      onPollUpdate={setFetchedJob}
       breadcrumbPrefix={[{ label: "Home" }]}
     />
   );

src/screens/BenchmarkRunDetailScreen.tsx

@@ -662,6 +662,7 @@ export function BenchmarkRunDetailScreen({
       onBack={goBack}
       buildDetailLines={buildDetailLines}
       pollResource={isRunning ? pollRun : undefined}
+      onPollUpdate={setFetchedRun}
       breadcrumbPrefix={[{ label: "Home" }, { label: "Benchmarks" }]}
     />
   );

src/screens/BlueprintDetailScreen.tsx

@@ -571,6 +571,7 @@ export function BlueprintDetailScreen({
           ? pollBlueprint
           : undefined
       }
+      onPollUpdate={setFetchedBlueprint}
     />
   );
 }

src/screens/ObjectDetailScreen.tsx

@@ -625,6 +625,7 @@ export function ObjectDetailScreen({ objectId }: ObjectDetailScreenProps) {
       onBack={goBack}
       buildDetailLines={buildDetailLines}
       pollResource={pollObject}
+      onPollUpdate={setFetchedObject}
     />
   );
 }

src/screens/ScenarioRunDetailScreen.tsx

@@ -370,6 +370,7 @@ export function ScenarioRunDetailScreen({
       onBack={goBack}
       buildDetailLines={buildDetailLines}
       pollResource={isRunning ? pollRun : undefined}
+      onPollUpdate={setFetchedRun}
       breadcrumbPrefix={breadcrumbPrefix}
     />
   );

src/screens/SnapshotDetailScreen.tsx

@@ -383,6 +383,7 @@ export function SnapshotDetailScreen({
       onBack={goBack}
       buildDetailLines={buildDetailLines}
       pollResource={snapshot.status === "pending" ? pollSnapshot : undefined}
+      onPollUpdate={setFetchedSnapshot}
     />
   );
 }