cp dines

Author: dines-rl

src/commands/devbox/scp.ts

@@ -14,11 +14,12 @@
  * with a temporary SSH config so each devbox uses its own key.
  */
 
-import { exec } from "child_process";
+import { execFile } from "child_process";
 import { promisify } from "util";
-import { writeFile, unlink, mkdir } from "fs/promises";
+import { writeFile, unlink } from "fs/promises";
 import { join } from "path";
 import { tmpdir } from "os";
+import { randomUUID } from "crypto";
 import { getClient } from "../../utils/client.js";
 import { output, outputError } from "../../utils/output.js";
 import {
@@ -28,7 +29,7 @@ import {
   SSHKeyInfo,
 } from "../../utils/ssh.js";
 
-const execAsync = promisify(exec);
+const execFileAsync = promisify(execFile);
 
 export interface SCPOptions {
   scpOptions?: string;
@@ -232,10 +233,11 @@ export async function scpFiles(src: string, dst: string, options: SCPOptions) {
         [srcRemote, dstRemote],
         proxyCommand,
       );
-      const configDir = join(tmpdir(), "runloop-scp");
-      await mkdir(configDir, { recursive: true });
-      const configPath = join(configDir, `scp-${Date.now()}.conf`);
-      await writeFile(configPath, configContent, { mode: 0o600 });
+      const configPath = join(tmpdir(), `rli-scp-${randomUUID()}.conf`);
+      const configHeader =
+        "# Temporary SSH config generated by `rli devbox scp` for a dual-remote transfer.\n" +
+        "# Safe to delete.\n\n";
+      await writeFile(configPath, configHeader + configContent, { mode: 0o600 });
 
       try {
         scpCommand = buildDualRemoteSCPCommand({
@@ -248,7 +250,8 @@ export async function scpFiles(src: string, dst: string, options: SCPOptions) {
           scpOptions: options.scpOptions,
         });
 
-        await execAsync(scpCommand.join(" "));
+        const [cmd, ...args] = scpCommand;
+        await execFileAsync(cmd, args);
       } finally {
         // Clean up temp config
         await unlink(configPath).catch(() => {});
@@ -267,7 +270,8 @@ export async function scpFiles(src: string, dst: string, options: SCPOptions) {
         scpOptions: options.scpOptions,
       });
 
-      await execAsync(scpCommand.join(" "));
+      const [cmd, ...args] = scpCommand;
+      await execFileAsync(cmd, args);
     }
 
     // Default: just output the destination for easy scripting