cp dines

Author: dines-rl

src/commands/blueprint/delete.ts

@@ -1,6 +1,5 @@
 /**
  * Delete blueprint command
- * Supports both blueprint ID (bpt_...) and name
  */
 
 import { getClient } from "../../utils/client.js";
@@ -11,41 +10,20 @@ interface DeleteOptions {
 }
 
 export async function deleteBlueprint(
-  nameOrId: string,
+  id: string,
   options: DeleteOptions = {},
 ) {
   try {
     const client = getClient();
 
-    let blueprintId = nameOrId;
-
-    // If it's not an ID, resolve by name
-    if (!nameOrId.startsWith("bpt_")) {
-      const result = await client.blueprints.list({ name: nameOrId });
-      const blueprints = result.blueprints || [];
-
-      if (blueprints.length === 0) {
-        outputError(
-          `Blueprint not found: ${nameOrId}`,
-          new Error("Blueprint not found"),
-        );
-        return;
-      }
-
-      // Use exact match if available, otherwise first result
-      const blueprint =
-        blueprints.find((b) => b.name === nameOrId) || blueprints[0];
-      blueprintId = blueprint.id;
-    }
-
-    await client.blueprints.delete(blueprintId);
+    await client.blueprints.delete(id);
 
     // Default: just output the ID for easy scripting
     if (!options.output || options.output === "text") {
-      console.log(blueprintId);
+      console.log(id);
     } else {
       output(
-        { id: blueprintId, status: "deleted" },
+        { id, status: "deleted" },
         { format: options.output, defaultFormat: "json" },
       );
     }

src/utils/commands.ts

@@ -469,8 +469,8 @@ export function createProgram(): Command {
     });
 
   blueprint
-    .command("delete <name-or-id>")
-    .description("Delete a blueprint by name or ID (IDs start with bpt_)")
+    .command("delete <id>")
+    .description("Delete a blueprint by ID")
     .alias("rm")
     .option(
       "-o, --output [format]",

tests/__tests__/commands/blueprint/delete.test.ts

@@ -6,12 +6,10 @@ import { jest, describe, it, expect, beforeEach } from "@jest/globals";
 
 // Mock dependencies using the path alias
 const mockDelete = jest.fn();
-const mockList = jest.fn();
 jest.unstable_mockModule("@/utils/client.js", () => ({
   getClient: () => ({
     blueprints: {
       delete: mockDelete,
-      list: mockList,
     },
   }),
 }));
@@ -28,106 +26,22 @@ describe("deleteBlueprint", () => {
     jest.clearAllMocks();
     (console.log as jest.Mock).mockClear();
     mockDelete.mockReset();
-    mockList.mockReset();
     mockOutput.mockReset();
     mockOutputError.mockReset();
   });
 
-  it("should delete a blueprint by ID directly", async () => {
+  it("should delete a blueprint by ID", async () => {
     mockDelete.mockResolvedValue(undefined);
 
     const { deleteBlueprint } = await import(
       "@/commands/blueprint/delete.js"
     );
     await deleteBlueprint("bpt_abc123", {});
 
-    expect(mockList).not.toHaveBeenCalled();
     expect(mockDelete).toHaveBeenCalledWith("bpt_abc123");
     expect(console.log).toHaveBeenCalledWith("bpt_abc123");
   });
 
-  it("should resolve blueprint by name and delete", async () => {
-    mockList.mockResolvedValue({
-      blueprints: [{ id: "bpt_resolved", name: "my-blueprint" }],
-    });
-    mockDelete.mockResolvedValue(undefined);
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("my-blueprint", {});
-
-    expect(mockList).toHaveBeenCalledWith({ name: "my-blueprint" });
-    expect(mockDelete).toHaveBeenCalledWith("bpt_resolved");
-    expect(console.log).toHaveBeenCalledWith("bpt_resolved");
-  });
-
-  it("should prefer exact name match when resolving by name", async () => {
-    mockList.mockResolvedValue({
-      blueprints: [
-        { id: "bpt_partial", name: "my-blueprint-v2" },
-        { id: "bpt_exact", name: "my-blueprint" },
-      ],
-    });
-    mockDelete.mockResolvedValue(undefined);
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("my-blueprint", {});
-
-    expect(mockDelete).toHaveBeenCalledWith("bpt_exact");
-    expect(console.log).toHaveBeenCalledWith("bpt_exact");
-  });
-
-  it("should fall back to first result when no exact name match", async () => {
-    mockList.mockResolvedValue({
-      blueprints: [
-        { id: "bpt_first", name: "my-blueprint-v1" },
-        { id: "bpt_second", name: "my-blueprint-v2" },
-      ],
-    });
-    mockDelete.mockResolvedValue(undefined);
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("my-blueprint", {});
-
-    expect(mockDelete).toHaveBeenCalledWith("bpt_first");
-    expect(console.log).toHaveBeenCalledWith("bpt_first");
-  });
-
-  it("should output error when blueprint name is not found", async () => {
-    mockList.mockResolvedValue({ blueprints: [] });
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("nonexistent-blueprint", {});
-
-    expect(mockOutputError).toHaveBeenCalledWith(
-      "Blueprint not found: nonexistent-blueprint",
-      expect.any(Error),
-    );
-    expect(mockDelete).not.toHaveBeenCalled();
-  });
-
-  it("should handle empty blueprints array from API", async () => {
-    mockList.mockResolvedValue({});
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("nonexistent", {});
-
-    expect(mockOutputError).toHaveBeenCalledWith(
-      "Blueprint not found: nonexistent",
-      expect.any(Error),
-    );
-    expect(mockDelete).not.toHaveBeenCalled();
-  });
-
   it("should output JSON format when requested", async () => {
     mockDelete.mockResolvedValue(undefined);
 
@@ -183,7 +97,7 @@ describe("deleteBlueprint", () => {
     expect(mockOutput).not.toHaveBeenCalled();
   });
 
-  it("should handle API errors on delete gracefully", async () => {
+  it("should handle API errors gracefully", async () => {
     const apiError = new Error("API Error: Forbidden");
     mockDelete.mockRejectedValue(apiError);
 
@@ -198,36 +112,20 @@ describe("deleteBlueprint", () => {
     );
   });
 
-  it("should handle API errors on list gracefully", async () => {
-    const apiError = new Error("API Error: Network failure");
-    mockList.mockRejectedValue(apiError);
+  it("should handle dependent snapshot errors gracefully", async () => {
+    const apiError = new Error(
+      "Blueprint has dependent snapshots and cannot be deleted",
+    );
+    mockDelete.mockRejectedValue(apiError);
 
     const { deleteBlueprint } = await import(
       "@/commands/blueprint/delete.js"
     );
-    await deleteBlueprint("some-name", {});
+    await deleteBlueprint("bpt_has_snapshots", {});
 
     expect(mockOutputError).toHaveBeenCalledWith(
       "Failed to delete blueprint",
       apiError,
     );
-    expect(mockDelete).not.toHaveBeenCalled();
-  });
-
-  it("should output resolved ID in text format when deleting by name", async () => {
-    mockList.mockResolvedValue({
-      blueprints: [{ id: "bpt_resolved_id", name: "named-blueprint" }],
-    });
-    mockDelete.mockResolvedValue(undefined);
-
-    const { deleteBlueprint } = await import(
-      "@/commands/blueprint/delete.js"
-    );
-    await deleteBlueprint("named-blueprint", { output: "json" });
-
-    expect(mockOutput).toHaveBeenCalledWith(
-      { id: "bpt_resolved_id", status: "deleted" },
-      { format: "json", defaultFormat: "json" },
-    );
   });
 });