Skip to content

Commit 5737476

Browse files
jason-rljason-rl
committed
Clarify that totalPage isn't total size, use plus symbol for hasMore
1 parent 7a9b98e commit 5737476

7 files changed

Lines changed: 26 additions & 26 deletions

File tree

‎src/commands/blueprint/list.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ const ListBlueprintsUI = ({
875875
data={blueprints}
876876
keyExtractor={(blueprint: BlueprintListItem) => blueprint.id}
877877
selectedIndex={selectedIndex}
878-
title={`blueprints[${totalCount}]`}
878+
title={`blueprints[${hasMore ? `${totalCount}+` : totalCount}]`}
879879
columns={blueprintColumns}
880880
emptyState={
881881
<Text color={colors.textDim}>
@@ -889,7 +889,7 @@ const ListBlueprintsUI = ({
889889
{!showPopup && (
890890
<Box marginTop={1} paddingX={1}>
891891
<Text color={colors.primary} bold>
892-
{figures.hamburger} {totalCount}
892+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
893893
</Text>
894894
<Text color={colors.textDim} dimColor>
895895
{" "}
@@ -907,7 +907,7 @@ const ListBlueprintsUI = ({
907907
</Text>
908908
) : (
909909
<Text color={colors.textDim} dimColor>
910-
Page {currentPage + 1} of {totalPages}
910+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
911911
</Text>
912912
)}
913913
</>
@@ -917,7 +917,7 @@ const ListBlueprintsUI = ({
917917
•{" "}
918918
</Text>
919919
<Text color={colors.textDim} dimColor>
920-
Showing {startIndex + 1}-{endIndex} of {totalCount}
920+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
921921
</Text>
922922
{search.submittedSearchQuery && (
923923
<>

‎src/commands/devbox/list.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,7 @@ const ListDevboxesUI = ({
712712
{!showPopup && (
713713
<Box marginTop={1} paddingX={1}>
714714
<Text color={colors.primary} bold>
715-
{figures.hamburger} {totalCount}
715+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
716716
</Text>
717717
<Text color={colors.textDim} dimColor>
718718
{" "}
@@ -730,7 +730,7 @@ const ListDevboxesUI = ({
730730
</Text>
731731
) : (
732732
<Text color={colors.textDim} dimColor>
733-
Page {currentPage + 1} of {totalPages}
733+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
734734
</Text>
735735
)}
736736
</>
@@ -740,7 +740,7 @@ const ListDevboxesUI = ({
740740
•{" "}
741741
</Text>
742742
<Text color={colors.textDim} dimColor>
743-
Showing {startIndex + 1}-{endIndex} of {totalCount}
743+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
744744
</Text>
745745
{search.submittedSearchQuery && (
746746
<>

‎src/commands/gateway-config/list.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ const ListGatewayConfigsUI = ({
630630
data={configs}
631631
keyExtractor={(config: GatewayConfigListItem) => config.id}
632632
selectedIndex={selectedIndex}
633-
title={`gateway_configs[${totalCount}]`}
633+
title={`gateway_configs[${hasMore ? `${totalCount}+` : totalCount}]`}
634634
columns={columns}
635635
emptyState={
636636
<Text color={colors.textDim}>
@@ -645,7 +645,7 @@ const ListGatewayConfigsUI = ({
645645
{!showPopup && (
646646
<Box marginTop={1} paddingX={1}>
647647
<Text color={colors.primary} bold>
648-
{figures.hamburger} {totalCount}
648+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
649649
</Text>
650650
<Text color={colors.textDim} dimColor>
651651
{" "}
@@ -663,7 +663,7 @@ const ListGatewayConfigsUI = ({
663663
</Text>
664664
) : (
665665
<Text color={colors.textDim} dimColor>
666-
Page {currentPage + 1} of {totalPages}
666+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
667667
</Text>
668668
)}
669669
</>
@@ -673,7 +673,7 @@ const ListGatewayConfigsUI = ({
673673
•{" "}
674674
</Text>
675675
<Text color={colors.textDim} dimColor>
676-
Showing {startIndex + 1}-{endIndex} of {totalCount}
676+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
677677
</Text>
678678
{search.submittedSearchQuery && (
679679
<>

‎src/commands/network-policy/list.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ const ListNetworkPoliciesUI = ({
660660
data={policies}
661661
keyExtractor={(policy: NetworkPolicyListItem) => policy.id}
662662
selectedIndex={selectedIndex}
663-
title={`network_policies[${totalCount}]`}
663+
title={`network_policies[${hasMore ? `${totalCount}+` : totalCount}]`}
664664
columns={columns}
665665
emptyState={
666666
<Text color={colors.textDim}>
@@ -674,7 +674,7 @@ const ListNetworkPoliciesUI = ({
674674
{!showPopup && (
675675
<Box marginTop={1} paddingX={1}>
676676
<Text color={colors.primary} bold>
677-
{figures.hamburger} {totalCount}
677+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
678678
</Text>
679679
<Text color={colors.textDim} dimColor>
680680
{" "}
@@ -692,7 +692,7 @@ const ListNetworkPoliciesUI = ({
692692
</Text>
693693
) : (
694694
<Text color={colors.textDim} dimColor>
695-
Page {currentPage + 1} of {totalPages}
695+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
696696
</Text>
697697
)}
698698
</>
@@ -702,7 +702,7 @@ const ListNetworkPoliciesUI = ({
702702
•{" "}
703703
</Text>
704704
<Text color={colors.textDim} dimColor>
705-
Showing {startIndex + 1}-{endIndex} of {totalCount}
705+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
706706
</Text>
707707
{search.submittedSearchQuery && (
708708
<>

‎src/commands/object/list.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ const ListObjectsUI = ({
705705
data={objects}
706706
keyExtractor={(obj: ObjectListItem) => obj.id}
707707
selectedIndex={selectedIndex}
708-
title={`storage_objects[${totalCount}]`}
708+
title={`storage_objects[${hasMore ? `${totalCount}+` : totalCount}]`}
709709
columns={columns}
710710
emptyState={
711711
<Text color={colors.textDim}>
@@ -720,7 +720,7 @@ const ListObjectsUI = ({
720720
{!showPopup && (
721721
<Box marginTop={1} paddingX={1}>
722722
<Text color={colors.primary} bold>
723-
{figures.hamburger} {totalCount}
723+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
724724
</Text>
725725
<Text color={colors.textDim} dimColor>
726726
{" "}
@@ -738,7 +738,7 @@ const ListObjectsUI = ({
738738
</Text>
739739
) : (
740740
<Text color={colors.textDim} dimColor>
741-
Page {currentPage + 1} of {totalPages}
741+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
742742
</Text>
743743
)}
744744
</>
@@ -748,7 +748,7 @@ const ListObjectsUI = ({
748748
•{" "}
749749
</Text>
750750
<Text color={colors.textDim} dimColor>
751-
Showing {startIndex + 1}-{endIndex} of {totalCount}
751+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
752752
</Text>
753753
{search.submittedSearchQuery && (
754754
<>

‎src/commands/secret/list.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ const ListSecretsUI = ({
525525
{!showPopup && (
526526
<Box marginTop={1} paddingX={1}>
527527
<Text color={colors.primary} bold>
528-
{figures.hamburger} {totalCount}
528+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
529529
</Text>
530530
<Text color={colors.textDim} dimColor>
531531
{" "}
@@ -543,7 +543,7 @@ const ListSecretsUI = ({
543543
</Text>
544544
) : (
545545
<Text color={colors.textDim} dimColor>
546-
Page {currentPage + 1} of {totalPages}
546+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
547547
</Text>
548548
)}
549549
</>
@@ -553,7 +553,7 @@ const ListSecretsUI = ({
553553
•{" "}
554554
</Text>
555555
<Text color={colors.textDim} dimColor>
556-
Showing {startIndex + 1}-{endIndex} of {totalCount}
556+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
557557
</Text>
558558
{search.submittedSearchQuery && (
559559
<>

‎src/commands/snapshot/list.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ const ListSnapshotsUI = ({
576576
data={snapshots}
577577
keyExtractor={(snapshot: SnapshotListItem) => snapshot.id}
578578
selectedIndex={selectedIndex}
579-
title={`snapshots[${totalCount}]`}
579+
title={`snapshots[${hasMore ? `${totalCount}+` : totalCount}]`}
580580
columns={columns}
581581
emptyState={
582582
<Text color={colors.textDim}>
@@ -591,7 +591,7 @@ const ListSnapshotsUI = ({
591591
{!showPopup && (
592592
<Box marginTop={1} paddingX={1}>
593593
<Text color={colors.primary} bold>
594-
{figures.hamburger} {totalCount}
594+
{figures.hamburger} {hasMore ? `${totalCount}+` : totalCount}
595595
</Text>
596596
<Text color={colors.textDim} dimColor>
597597
{" "}
@@ -609,7 +609,7 @@ const ListSnapshotsUI = ({
609609
</Text>
610610
) : (
611611
<Text color={colors.textDim} dimColor>
612-
Page {currentPage + 1} of {totalPages}
612+
Page {currentPage + 1} of {hasMore ? `${totalPages}+` : totalPages}
613613
</Text>
614614
)}
615615
</>
@@ -619,7 +619,7 @@ const ListSnapshotsUI = ({
619619
•{" "}
620620
</Text>
621621
<Text color={colors.textDim} dimColor>
622-
Showing {startIndex + 1}-{endIndex} of {totalCount}
622+
Showing {startIndex + 1}-{endIndex} of {hasMore ? `${totalCount}+` : totalCount}
623623
</Text>
624624
{search.submittedSearchQuery && (
625625
<>

0 commit comments

Comments
 (0)