Skip to content

Commit 8f4145a

Browse files
authored
fix(cli): use allSettled() instead of all() so one bad download doesn't spoil the barrel (#178)
1 parent 78f8f55 commit 8f4145a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/commands/benchmark-job/logs.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ async function runWithConcurrency<T>(
272272
{ length: Math.min(maxConcurrency, tasks.length) },
273273
() => worker(),
274274
);
275-
await Promise.all(workers);
275+
await Promise.allSettled(workers);
276276
return results;
277277
}
278278

@@ -349,7 +349,8 @@ export async function downloadBenchmarkJobLogs(
349349
`\nDownloading logs for ${targets.length} scenario run(s) to ${chalk.bold(outputDir)}\n`,
350350
);
351351

352-
// Download logs in parallel with a max concurrency of 50
352+
// Download logs in parallel with a max concurrency of 50.
353+
// Bumping to 100 yields no improvement in simple manual testing.
353354
const MAX_CONCURRENCY = 50;
354355
let succeeded = 0;
355356

0 commit comments

Comments
 (0)