Commit ca77634
authored
fix(benchmark): scenario status in run view and some additional tweaks (#98)
## Description
<!-- Provide a brief description of your changes -->
Summary of Pending Changes (3 files modified)
1. src/components/StatusBadge.tsx (Minor change)
- Changed "COMPLETED" to "COMPLETE" for consistency
- Updated label from "Completed" to "Complete"
2. src/screens/BenchmarkJobDetailScreen.tsx (+59 lines)
Main feature: Fetch actual benchmark run names instead of showing IDs
- Added import for getBenchmarkRun service
- Added runNames state to cache fetched run names
- Added React effect that:
- Collects all run IDs from outcomes and in-progress runs
- Fetches full run details in parallel using getBenchmarkRun()
- Extracts names (falls back to ID if name is null)
- Stores in a Map for fast lookup
- Updated run display logic to use fetched names instead of:
- Old: agent names or "Unknown Agent"
- New: actual benchmark run names from API
3. src/screens/BenchmarkRunDetailScreen.tsx (+263 lines, -53 lines)
Major feature: Display scenario runs within benchmark run details
Added features:
- Scenario runs state and loading
- Overall status section that calculates aggregate status from scenario
runs
- Shows "Failed", "Complete", "In Progress", or "Not Started"
- Displays scenario count
- Scenario runs table with columns:
- ID
- Name
- Status (with colors)
- Score
- Auto-refresh scenario runs every 5 seconds when run is active
- Polling integration to refresh scenario runs alongside run details
Removed:
- Environment Variables section (removed from both detail view and
polling display)
**Note:** PR titles should follow [Conventional
Commits](https://www.conventionalcommits.org/) format (e.g.,
`feat(devbox): add support for custom env vars` or `fix(snapshot):
resolve pagination issue`) as they are used for automatic release notes
generation.
## Type of Change
<!-- Mark the relevant option with an 'x' -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update
- [ ] Code refactoring
- [ ] Performance improvement
- [ ] Test updates
## Related Issues
<!-- Link to related issues using #issue-number -->
Closes #
## Changes Made
<!-- Describe the changes in detail -->
## Testing
<!-- Describe how you tested your changes -->
- [ ] I have tested locally
- [ ] I have added/updated tests
- [ ] All existing tests pass
## Checklist
- [ ] My code follows the code style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published
## Screenshots (if applicable)
<!-- Add screenshots to help explain your changes -->
## Additional Notes
<!-- Any additional information that reviewers should know -->1 parent a3c1b7a commit ca77634
3 files changed
Lines changed: 287 additions & 53 deletions
File tree
- src
- components
- screens
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
| 143 | + | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
66 | 70 | | |
67 | 71 | | |
68 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
69 | 114 | | |
70 | 115 | | |
71 | 116 | | |
| |||
496 | 541 | | |
497 | 542 | | |
498 | 543 | | |
499 | | - | |
| 544 | + | |
500 | 545 | | |
501 | 546 | | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
502 | 550 | | |
503 | 551 | | |
504 | | - | |
| 552 | + | |
505 | 553 | | |
506 | 554 | | |
507 | 555 | | |
508 | 556 | | |
509 | 557 | | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | 558 | | |
515 | 559 | | |
516 | | - | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
517 | 564 | | |
518 | 565 | | |
519 | 566 | | |
| |||
525 | 572 | | |
526 | 573 | | |
527 | 574 | | |
528 | | - | |
| 575 | + | |
529 | 576 | | |
530 | 577 | | |
531 | 578 | | |
| |||
0 commit comments