Skip to content

feat(cli): respect NO_COLOR environment variable in REPL banner #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superjackche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(cli): respect NO_COLOR environment variable in REPL banner #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/runmat-cli/src/commands/repl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ fn print_repl_banner(config: &RunMatConfig, engine: &RunMatSession) {
}

fn detect_banner_capabilities() -> BannerCapabilities {
let decorated = atty::is(atty::Stream::Stdout)
Copy link
Copy Markdown
Contributor

@gneeri gneeri Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this update. That said, I believe that supports_color (below ln 147/9) already handles the NO_COLOR env var. Can you confirm that this is NOT the case.

let no_color = std::env::var_os("NO_COLOR").is_some();
let decorated = !no_color
&& atty::is(atty::Stream::Stdout)
&& std::env::var("TERM")
.map(|term| term != "dumb")
.unwrap_or(true);
Expand Down
Loading