Skip to content

removing stale cached wgpu pipelines#327

Open
nallana wants to merge 2 commits into
devfrom
remove-stale-cached-pipelines
Open

removing stale cached wgpu pipelines#327
nallana wants to merge 2 commits into
devfrom
remove-stale-cached-pipelines

Conversation

@nallana
Copy link
Copy Markdown
Contributor

@nallana nallana commented May 5, 2026

Note

Medium Risk
Touches wgpu pipeline warmup/caching logic and adds automatic eviction of cached entries, which could affect startup behavior and GPU compatibility if the validation/eviction conditions are wrong.

Overview
During wgpu warmup, cached on-disk pipelines are now validated via wgpu error scopes and any entries that fail creation or a post-create noop pass are treated as incompatible and removed.

warmup_from_disk now accepts a callback to evict the corresponding in-memory cached pipeline key, and shared cleanup logic removes both the .json metadata and .wgsl shader files for the stale entry. (Validation-scope handling is gated to non-wasm32 and is guarded against panics to avoid leaking scopes.)

Reviewed by Cursor Bugbot for commit f05d1bc. Bugbot is set up for automated code reviews on this repo. Configure here.

@nallana nallana requested a review from gneeri May 5, 2026 17:44
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
runmat Ready Ready Preview, Comment, Open in v0 May 6, 2026 3:31pm

Request Review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1f3c39a. Configure here.

Comment thread crates/runmat-accelerate/src/backend/wgpu/warmup.rs Outdated
Copy link
Copy Markdown
Contributor

@gneeri gneeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would address the cursorbot error about leaked scope, but otherwise, this looks good.

Co-authored-by: Nabeel Allana <contact@dystr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants